Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show autoplay blocked indicator only when play is requested #7436

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Dec 15, 2020

Resolves brave/brave-browser#13167

DidBlockContentType(ContentSettingsType::AUTOPLAY) should only be called when checking autoplay content is from autoplay by attribute or autoplay by method .

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

STR in brave/brave-browser#13167

@darkdh darkdh requested a review from a team as a code owner December 15, 2020 04:49
@darkdh darkdh force-pushed the autoplay-did-block branch from 10066a1 to 81a0082 Compare December 15, 2020 04:52
@darkdh darkdh force-pushed the autoplay-did-block branch from 81a0082 to 9f8c1f7 Compare December 15, 2020 17:44
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src changes LGTM

@darkdh
Copy link
Member Author

darkdh commented Dec 15, 2020

Known CI issue

11:50:24  Failing tests:
11:50:24  	TestTargetName:
11:50:24  		-[AdsWrapperTest testPreferencePersistance]

https://ci.brave.com/job/pr-brave-browser-autoplay-did-block-ios/4/execution/node/164/log/

@darkdh darkdh merged commit c43e163 into master Dec 15, 2020
@darkdh darkdh deleted the autoplay-did-block branch December 15, 2020 20:09
@darkdh darkdh added this to the 1.20.x - Nightly milestone Dec 15, 2020
@darkdh darkdh self-assigned this Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoplay blocked indicator shows up when media is not autoplayed
3 participants