Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style private windows with Tor purple like regular private windows #1383

Closed
tildelowengrimm opened this issue Oct 1, 2018 · 3 comments · Fixed by brave/brave-core#546
Closed

Style private windows with Tor purple like regular private windows #1383

tildelowengrimm opened this issue Oct 1, 2018 · 3 comments · Fixed by brave/brave-core#546
Assignees
@petemill
Labels
feature/tor QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes
Milestone
0.55.x - Release ...

Comments

@tildelowengrimm
Copy link
Contributor

tildelowengrimm commented Oct 1, 2018 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#546

Description

Right now, windows with Tor have default Chrome. Instead, they should use the same purple styling as regular private windows.
@bbondy bbondy assigned petemill and unassigned petemill and riastradh-brave Oct 2, 2018
@bbondy
Copy link
Member

bbondy commented Oct 2, 2018 •
edited
Loading

@petemill browser_->profile()->IsTorProfile()

@darkdh darkdh assigned petemill and unassigned darkdh Oct 2, 2018
petemill added a commit to brave/brave-core that referenced this issue Oct 2, 2018
@petemill
Use incognito theme for Tor profile windows
05703bc 
Forces tor profiles to be recognised as 'incognito' for theme.
Also ensures that complementing omnibox theme is used.
Also ensures that complementing dark 'native' theme is used.
Fix brave/brave-browser#1383
@petemill petemill mentioned this issue Oct 2, 2018
Merged
11 tasks
@petemill
Copy link
Member

petemill commented Oct 2, 2018

Test plan on PR brave/brave-core#546

@btlechowski
Copy link

btlechowski commented Oct 10, 2018 •
edited by srirambv
Loading

Verification passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows 7

image

Verified passed with

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

screen shot 2018-10-11 at 9 47 34 am

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux
  • Window frame doesn't change on Linux because of GTK+ and Classic theme which overrides the app setting
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
feature/tor QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Use incognito theme for Tor profile windows brave/brave-core
9 participants
@tildelowengrimm @petemill @bbondy @bsclifton @darkdh @srirambv @LaurenWags @riastradh-brave @btlechowski