Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use incognito theme for Tor profile windows #546

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Conversation

petemill
Copy link
Member

@petemill petemill commented Oct 2, 2018

Forces tor profiles to be recognized as 'incognito' for theme.
Also ensures that complementing omnibox theme is used.
Also ensures that complementing dark 'native' theme is used.
Fix brave/brave-browser#1383

image

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • Open Tor Window
  • Toolbar should be purple
  • Omnibox should be purple
  • Visit chrome://about
  • Security chip text should be white
    image

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Forces tor profiles to be recognised as 'incognito' for theme.
Also ensures that complementing omnibox theme is used.
Also ensures that complementing dark 'native' theme is used.
Fix brave/brave-browser#1383
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsclifton bsclifton merged commit b99b087 into master Oct 2, 2018
@bsclifton bsclifton deleted the ui/tor-theme branch October 2, 2018 05:42
bsclifton added a commit that referenced this pull request Oct 2, 2018
Use incognito theme for Tor profile windows
bsclifton added a commit that referenced this pull request Oct 2, 2018
Use incognito theme for Tor profile windows
@bsclifton
Copy link
Member

master b99b087
0.56.x c843eed
0.55.x 82d66a7

@bsclifton bsclifton added merged/0.55.x and removed UI labels Oct 2, 2018
@simonhong
Copy link
Member

I wrote below comment on wrong PR :)
Just question, don't we use same theme for guest window?

@petemill
Copy link
Member Author

petemill commented Oct 2, 2018

@simonhong at the moment Guest Window does not use the 'Private' theme - it's a different code path which uses normal light / dark. Maybe it should? Chromium doesn't use incognito theme for Guest Window though.

@simonhong
Copy link
Member

Guest window seems to use same private newtab with incognito window.
So, I thought like that :)

@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style private windows with Tor purple like regular private windows
4 participants