Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Today: support Japanese content feed #14306

Closed
petemill opened this issue Feb 23, 2021 · 1 comment · Fixed by brave/brave-core#7676
Closed

Brave Today: support Japanese content feed #14306

petemill opened this issue Feb 23, 2021 · 1 comment · Fixed by brave/brave-core#7676

Comments

@petemill
Copy link
Member

Description

When the user's OS is set to Japanese language, we should load the Japanese content feed. This feed contains a different set of sources, mainly local to Japan.

Steps to Reproduce

Localised content is shown

  1. Set OS to Japanese

  2. Restart Brave

  3. Open NTP and scroll down.
    Expected: Brave Today has all japanese content

  4. Set OS to English or French or any language except Japanese

  5. Restart Brave

  6. Open NTP and scroll down.
    Expected: Brave Today has all English / default sources content

Brave Today is enabled by default for Japanese language users, as is currently so for English language users only

  1. Quit Brave
  2. Set OS to Japanese
  3. Start Brave with clean profile
  4. Open NTP
    Expected: Brave Today should be showing / enabled by default

Notes

When switching between English and Japanese OS languages, upon restart we expect the browser to load the expected feed sources (default "english" content sources for all languages, and "japanese" content sources only for japanese language. However, when switching to a localized feed which the user has made changes to previously (i.e. turning publishers on or off), those same changes should still be respected.

@stephendonner
Copy link

Verification PASSED on macOS beta using build

Brave 1.22.55 Chromium: 89.0.4389.72 (Official Build) beta (x86_64)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS macOS Version 11.2.3 (Build 20D91)

Prerequisites (macOS):

  • Set OS language to Japan
  • Set OS region to Japan
  • Set OS date/time format to Japan

Test Case #1 (clean profile)

  • ensured that the Japan source is being used for Brave Today
  • ensured that Japanese sources are being displayed under the Customize Dashboard via Brave Today
  • ensured that disabling Brave Today via Customize Dashboard works as expected
  • ensured that you can restore Brave Today to the default state via Reset Brave Today sources
Example Example Example
braveToday1 braveToday2 braveToday3

Test Case #2 (switching between Japan/United States)

  • ensured that the Japan source is being used for Brave Today when Japan is being selected as the default locale/language
  • ensured that the USA source is being used for Brave Today when United States/English is selected as the default locale/language
  • ensured that the source selection settings are remembered when switching between the two locales
    • Disabled all feeds for Technology & Crypto using Japan
    • Enabled all feeds for Technology & Crypto using United States
    • ensured that switching between the two sources saves the above selections

Additionally, I filed or asked about issues which were filed as:

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 9, 2021
@rebron rebron changed the title Brave Today: support japanese content feed Brave Today: support Japanese content feed Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants