Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift for 1.22.x: Brave Today Japanese content #8094

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Uplift for 1.22.x: Brave Today Japanese content #8094

merged 1 commit into from
Mar 9, 2021

Conversation

petemill
Copy link
Member

@petemill petemill commented Mar 1, 2021 •
edited
Loading

Uplift #7676 (brave/brave-browser#14306) to 1.22.x, which just missed the migration window.

@petemill petemill requested a review from a team March 1, 2021 18:15
@petemill petemill self-assigned this Mar 1, 2021
@kjozwiak kjozwiak added this to the 1.22.x - Beta milestone Mar 1, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Mar 8, 2021

Restarting macOS due to build failing as per https://ci.brave.com/job/pr-brave-browser-today-ja-1.22.x-macos/1/execution/node/165/log/.

14:49:14  FAILED: obj/brave/common/extensions/api/generated_api_registration/generated_api_registration.o

audit_deps failed on post-init due to a known failure as per https://ci.brave.com/job/pr-brave-browser-today-ja-1.22.x-post-init/1/execution/node/145/log/. However, this doesn't block uplift as it's not related to this specific PR.

kjozwiak
kjozwiak approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.22.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #7676 (comment).

@kjozwiak kjozwiak merged commit 38cf64d into 1.22.x Mar 9, 2021
@kjozwiak kjozwiak deleted the today-ja-1.22.x branch March 9, 2021 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@petemill petemill

Labels
None yet
Projects
None yet
Milestone
1.22.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@petemill @kjozwiak