-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove chrome-browser-browsing_data-chrome_browsing_data_remover_delegate_factory.cc.patch #14819
Comments
…gate_factory.cc.patch This patch could be removed in favour of a chromium_src override that would define its version of ChromeBrowsingDataRemoverDelegateFactory's BuildServiceInstanceFor() to simply return an instance of BraveBrowsingDataRemoverDelegate(), instead of patching the original method from upstream (which doesn't do anything else other than returning an instance of ChromeBrowsingDataRemoverDelegate). Resolves brave/brave-browser#14819
…gate_factory.cc.patch This patch could be removed in favour of a chromium_src override that would define its version of ChromeBrowsingDataRemoverDelegateFactory's BuildServiceInstanceFor() to simply return an instance of BraveBrowsingDataRemoverDelegate(), instead of patching the original method from upstream (which doesn't do anything else other than returning an instance of ChromeBrowsingDataRemoverDelegate). Resolves brave/brave-browser#14819
Closing as per review comments in the associated PR |
Verified
Confirmed that the UI reads Steps:
Verification passed on
Verified test plan from #8231 and #8826 Verificationchanged Verification passed on
changed Steps:
|
Description
This patch could be removed in favour of a chromium_src override that would define its own version of
ChromeBrowsingDataRemoverDelegateFactory::BuildServiceInstanceFor()
to simply return an instance ofBraveBrowsingDataRemoverDelegate()
, instead of patching the original method from upstream (which doesn't do anything else other than returning an instance ofChromeBrowsingDataRemoverDelegate
).Brave version (brave://version info)
Brave 1.24.2 (Chromium 89.0.4389.90)
Miscellaneous Information:
This removal references a patch initially introduced with #8231 (and later modified for #8826) so please use the test plan detailed in brave/brave-core#4624 for QA purposes (i.e. check that things continue to work).
The text was updated successfully, but these errors were encountered: