Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields settings are not cleared via clear browsing dialog with non all time range #8231

Closed
simonhong opened this issue Feb 13, 2020 · 1 comment · Fixed by brave/brave-core#4624

Comments

@simonhong
Copy link
Member

simonhong commented Feb 13, 2020

Shields setting is only cleared with All time time range.
and shields settings is not counted.
When user opens clear browsing data dialog, it shows settings count by the sub-label.
that number doesn't include shields setting.
Screen Shot 2020-02-13 at 5 57 11 PM

Steps to reproduce

  1. Launch browser with clean profile
  2. Load www.brave.com and turn off Cross-site trackers blocked via shields panel
  3. Launch Clear browsing data dialog via brave://settings/clearBrowserData
  4. Check Site Settings have 1 Site as a label with Last hour time range
  5. Push clear button and check label has None
  6. Load www.brave.com and check Cross-site trackers blocked is turned
@btlechowski
Copy link

btlechowski commented Mar 25, 2020

Verification passed on

Brave 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

Verified test plan from the description

Verified 1 site is shown in Clear browsing data under Site and Shield Settings

image

  • Verified that shield settings are reverted to default after clearing browsing data for Last hour.
  • Verified that shield settings are reverted to default after clearing browsing data for All time hour.
  • Verified that clearing Site and Shield Settings on exit works
  • Verified that there is 0 entries after clearing Site and Shield Settings

image

Verification passed on

Brave 1.7.74 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description
  • Verified that shield settings are cleared along with site settings when Site and Shield settings
    checkbox is checked with Last hour range in Advanced settings in Clear browsing data dialog
  • Verified that shield settings are reverted to default after clearing browsing data for Last hour
  • Verified that shield settings are reverted to default after clearing browsing data for All time hours.
  • Verified that clearing Site and Shield Settings on exit works
  • Verified that there is 0 or None entries after clearing Site and Shield Settings in Clear browsing data

Verification PASSED on macOS 10.15.3 x64 Catalina using the following build:

Brave | 1.7.86 Chromium: 80.0.3987.163 (Official Build) (64-bit)
-- | --
Revision | e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS | macOS Version 10.15.3 (Build 19D76)
  • Verified that shield settings are cleared along with site settings when Site and Shield settings
    checkbox is checked with Last hour range in Advanced settings in Clear browsing data dialog
  • Verified that shield settings are reverted to default after clearing browsing data for Last hour
  • Verified that shield settings are reverted to default after clearing browsing data for All time hours.
  • Verified that clearing Site and Shield Settings on exit works
  • Verified that there is 0 or None entries after clearing Site and Shield Settings in Clear browsing data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment