Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to define the minimum width and margin for the Rewards pages for the desktop #1556

Closed
jenn-rhim opened this issue Oct 12, 2018 · 1 comment · Fixed by brave/brave-core#721

Comments

@jenn-rhim
Copy link

Description

Feature components of Brave Rewards-- Ads, Contributions, Tips module, are responsive indefinitely that the content display gets broken below a certain window size.
screen shot 2018-10-12 at 2 15 39 pm

Please define the minimum width to 1024, which will preserve the content as well as keeping the margins for the page.

image

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (chrome://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
  • Does it reproduce on browser-laptop?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@bbondy bbondy added this to the 1.x Backlog milestone Oct 16, 2018
@rebron rebron added priority/P5 Not scheduled. Don't anticipate work on this any time soon. priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Oct 19, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.57.x - Dev Oct 22, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 24, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 26, 2018

Verification Passed on

Brave 0.57.3 Chromium: 70.0.3538.67 (Official Build) dev (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows

image

Verified passed with

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta(64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

Verification passed on

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta(64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants