This repository has been archived by the owner on May 13, 2024. It is now read-only.
Enforces 1024px min-width for settingsPage #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanml
commented
Oct 23, 2018
| @@ -15,7 +15,7 @@ exports[`WelcomePage tests basic tests matches the snapshot 1`] = ` | |||
| .c0 { | |||
| background: #f2f4f7; | |||
| min-height: 100vh; | |||
| width: 100%; | |||
| min-width: 1024px; | |||
There was a problem hiding this comment.
Note: This enforces the same behavior on the desktop welcome page, which seems desirable as we use the same SettingsPage component. This will not however, do so for the mobile welcome page, as it does not render inside the SettingsPage component.
NejcZdovc
approved these changes
Oct 23, 2018
18 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #230
Related: brave/brave-browser#1556
Before:
After:
