Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix localization for brave non generated strings #1568

Closed
bbondy opened this issue Oct 14, 2018 · 0 comments
Closed

Fix localization for brave non generated strings #1568

bbondy opened this issue Oct 14, 2018 · 0 comments
Assignees
@bbondy
Labels
QA/No
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Oct 14, 2018

It was at some point accidentally commented out, and then removed in a later refactoring. This is to re-add it as it was meant to be so the strings get uploaded to Transifex.
@bbondy bbondy added this to the 0.55.x milestone Oct 14, 2018
@bbondy bbondy self-assigned this Oct 14, 2018
bbondy added a commit that referenced this issue Oct 14, 2018
@bbondy
Upload non-generated strings to Transifex too
9783a19 
Fix #1568

This was accidentally removed in the past in
b390ac4 because it was accidentally
commented out before that.
@bbondy bbondy added the QA/No label Oct 14, 2018
@bbondy bbondy mentioned this issue Oct 14, 2018
Merged
16 tasks
bbondy added a commit that referenced this issue Oct 14, 2018
@bbondy
Upload non-generated strings to Transifex too
ad6591d 
Fix #1568

This was accidentally removed in the past in
b390ac4 because it was accidentally
commented out before that.
petemill pushed a commit to brave/brave-core that referenced this issue Jul 27, 2020
@bbondy
Upload non-generated strings to Transifex too
d54fa95 
Fix brave/brave-browser#1568

This was accidentally removed in the past in
9d0816d because it was accidentally
commented out before that.
petemill pushed a commit to brave/brave-core that referenced this issue Jul 28, 2020
@bbondy
Upload non-generated strings to Transifex too
5dab5e3 
Fix brave/brave-browser#1568

This was accidentally removed in the past in
1fa6602 because it was accidentally
commented out before that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
QA/No
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

No branches or pull requests
1 participant
@bbondy