Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload non-generated strings to Transifex too #1569

Merged
merged 2 commits into from
Oct 14, 2018
Merged

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Oct 14, 2018

Fix #1568
Fix #1570

This was accidentally removed in the past in
b390ac4 because it was accidentally
commented out before that.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@bbondy bbondy self-assigned this Oct 14, 2018
@bbondy bbondy requested a review from NejcZdovc October 14, 2018 14:26
Fix #1568

This was accidentally removed in the past in
b390ac4 because it was accidentally
commented out before that.
@bbondy bbondy merged commit c29820a into master Oct 14, 2018
bbondy added a commit that referenced this pull request Oct 14, 2018
Upload non-generated strings to Transifex too
bbondy added a commit that referenced this pull request Oct 14, 2018
Upload non-generated strings to Transifex too
@bbondy
Copy link
Member Author

bbondy commented Oct 14, 2018

master: c29820a
0.56.x: 78e2a26
0.55.x: abf689e

@bbondy bbondy removed the 0.55.x label Jan 14, 2019
@bbondy bbondy deleted the fix-non-generated-strings branch January 24, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants