Ephemeral Storage Keep Alive doesn't respect the flag

[srirambv]

Test Cases:

• Run through all the cases under https://dev-pages.brave.software/storage/ephemeral-storage.html

Note: You'll need to do the following before running through the ephemeral-storage checks:

• launch Brave and check brave://version/?show-variations-cmd (you'll be missing the needed seed)
• relaunch Brave again and check brave://version/?show-variations-cmd (you should have the needed seed)

Once you pull the needed seed from griffin, you'll be able to run through the passes:

Description

Ephemeral Storage Keep Alive doesn't respect the flag

Steps to Reproduce

1. Clean install 1.26.11 x64 nightly desktop build
2. Enable only brave://flags/#brave-ephemeral-storage
3. Do not enable brave://flags/#brave-ephemeral-storage-keep-alive let it be default
4. Restart browser and visit https://dev-pages.brave.software/storage/keep-alive.html and run through both the tests
5. Results are same as expected even though the keep-alive flag is not enabled which is supposed to control the behaviour

Actual result:

Ephemeral Storage Keep Alive doesn't respect the flag

Expected result:

Ephemeral Storage Keep Alive should be controlled by the flag

Reproduces how often:

Easy

Desktop Brave version:

Brave	1.26.11 Chromium: 90.0.4430.93 (Official Build) nightly (64-bit)
Revision	4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS	Linux

Version/Channel Information:

• Can you reproduce this issue with the current release? NA
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

On Android, the Should not Keep-Alive Test fails as the remote frame doesn't set value as empty for which #15646 is logged

cc: @pes10k @bridiver

[kjozwiak]

@brave/legacy_qa we'll need to run through all the cases under https://dev-pages.brave.software/storage/ephemeral-storage.html and ensure everything is still working as expected as requested by @bridiver via Slack. We can skip the https://dev-pages.brave.software/storage/keep-alive.html checks.

[LaurenWags]

Verified passed with

Brave	1.24.86 Chromium: 90.0.4430.212 (Official Build) (x86_64)
Revision	e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS	macOS Version 10.15.7 (Build 19H1030)

Verified the six test configurations from https://dev-pages.brave.software/storage/ephemeral-storage.html:

• Confirmed all 6 tables were as expected for the Ephemeral Storage Enabled + Cross-site cookies blocked case
• Confirmed all 6 tables were as expected for the Ephemeral Storage Enabled + Cookies blocked case
• Confirmed all 6 tables were as expected for the Ephemeral Storage Enabled + All cookies allowed case
• Confirmed all 6 tables were as expected for the Ephemeral Storage Disabled + Cross-site cookies blocked case
• Confirmed all 6 tables were as expected for the Ephemeral Storage Disabled + Cookies blocked case
• Confirmed all 6 tables were as expected for the Ephemeral Storage Disabled + All cookies allowed case

---

Verification passed on

Brave | 1.24.86 Chromium: 90.0.4430.212 (Official Build) (64-bit)
-- | --
Revision | e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS | Windows 10 OS Version 2004 (Build 19041.985)

Enabled flag and relaunched brave and ensured ephemeral storage seed in shown in brave://version/?show-variations-cmd

Enable Ephemeral Storage flag	brave://version/?show-variations-cmd

Verified the six test configurations from https://dev-pages.brave.software/storage/ephemeral-storage.html:

Case 1	Case 2**	Case 3**	Case 4**	Case 5**	Case 6**

---

Verification passed on

Brave	1.24.86 Chromium: 90.0.4430.212 (Official Build) (64-bit)
Revision	e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS	Ubuntu 18.04 LTS

Verified the six test configurations from https://dev-pages.brave.software/storage/ephemeral-storage.html:

• Confirmed all 6 tables were as expected for the Ephemeral Storage Enabled + Cross-site cookies blocked case
• Confirmed all 6 tables were as expected for the Ephemeral Storage Enabled + Cookies blocked case
• Confirmed all 6 tables were as expected for the Ephemeral Storage Enabled + All cookies allowed case
• Confirmed all 6 tables were as expected for the Ephemeral Storage Disabled + Cross-site cookies blocked case
• Confirmed all 6 tables were as expected for the Ephemeral Storage Disabled + Cookies blocked case
• Confirmed all 6 tables were as expected for the Ephemeral Storage Disabled + All cookies allowed case