Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix keep alive flag value #8787

Merged
merged 1 commit into from
May 14, 2021
Merged

fix keep alive flag value #8787

merged 1 commit into from
May 14, 2021

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented May 12, 2021

Resolves brave/brave-browser#15815

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bridiver bridiver requested a review from yrliou May 12, 2021 23:02
@bridiver bridiver requested a review from a team as a code owner May 12, 2021 23:02
@bridiver bridiver self-assigned this May 12, 2021
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bridiver
Copy link
Collaborator Author

unrelated test failures and this was also verified in #8804

@bridiver bridiver merged commit 34b3b0b into master May 14, 2021
@bridiver bridiver deleted the keep-alive-flag branch May 14, 2021 14:29
@bridiver bridiver added this to the 1.26.x - Nightly milestone May 14, 2021
brave-builds pushed a commit that referenced this pull request May 14, 2021
bridiver added a commit that referenced this pull request May 14, 2021
@kjozwiak
Copy link
Member

kjozwiak commented May 18, 2021

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.26.22 Chromium: 91.0.4472.57 (Official Build) nightly (64-bit)
--- | ---
Revision | e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS | Windows 10 OS Version 2009 (Build 19042.964)

Test Case #1 (running through https://dev-pages.brave.software/storage/index.html)

Went through https://dev-pages.brave.software/storage/index.html and ensured each step passed/displayed the expected values:

Step 1 Step 2 Step 3 Step 4 Step 5 Step 6
step1 step2 step3 step4 step5 step6

Test Case #2 (running through https://dev-pages.brave.software/storage/keep-alive.html)

Test #1 - Keep Alive Enabled Test #1 - Keep Alive Disabled
keepAliveEnabled keepAliveDisabled
Test #2 - Keep Alive Enabled Test #2 - Keep Alive Disabled
NotAliveEnabled NotAliveDisabled

Verification PASSED on Samsung S10+ running Android 11 using the following build:

Brave | 1.26.22 Chromium: 91.0.4472.57

Test Case #1 (running through https://dev-pages.brave.software/storage/index.html)

Went through https://dev-pages.brave.software/storage/index.html and ensured each step passed/displayed the expected values:

Step 1 Step 2 Step 3 Step 4 Step 5 Step 6
Screenshot_20210517-210353_Brave - Nightly Screenshot_20210517-210419_Brave - Nightly Screenshot_20210517-210518_Brave - Nightly Screenshot_20210517-210551_Brave - Nightly Screenshot_20210517-210628_Brave - Nightly Screenshot_20210517-210727_Brave - Nightly

Test Case #2 (running through https://dev-pages.brave.software/storage/keep-alive.html)

Test #1 - Keep Alive Enabled Test #1 - Keep Alive Disabled
Screenshot_20210517-212510_Brave - Nightly Screenshot_20210517-212556_Brave - Nightly
Test #2 - Keep Alive Enabled Test #2 - Keep Alive Disabled
Screenshot_20210517-212734_Brave - Nightly Screenshot_20210517-212836_Brave - Nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ephemeral Storage Keep Alive doesn't respect the flag
4 participants