Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix keep alive flag value (uplift to 1.24.x) #8810

Merged
merged 1 commit into from
May 18, 2021
Merged

fix keep alive flag value (uplift to 1.24.x) #8810

merged 1 commit into from
May 18, 2021

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented May 14, 2021 •
edited by kjozwiak
Loading

Uplift of #8787
Resolves brave/brave-browser#15815

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bridiver bridiver added this to the 1.24.x - Release #4 milestone May 14, 2021
@bridiver bridiver requested a review from a team May 14, 2021 16:53
@bridiver bridiver requested a review from a team as a code owner May 14, 2021 16:53
@kjozwiak
Copy link
Member

post-init failed audit-deps due to several warning(s) as per https://ci.brave.com/job/pr-brave-browser-pr8787_keep-alive-flag_1.24.x-post-init/1/execution/node/145/log/. However, these warning(s) are known and unrelated to this specific PR.

kjozwiak
kjozwiak approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.24.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8787 (comment).

@kjozwiak kjozwiak merged commit e38e958 into 1.24.x May 18, 2021
@kjozwiak kjozwiak deleted the pr8787_keep-alive-flag_1.24.x branch May 18, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@bridiver bridiver

Labels
None yet
Projects
None yet
Milestone
1.24.x - Release #4
Development

Successfully merging this pull request may close these issues.
2 participants
@bridiver @kjozwiak