Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snap custom Brave ad notifications to the edge of the screen #17527

Closed
tmancey opened this issue Aug 17, 2021 · 1 comment · Fixed by brave/brave-core#10018
Closed

Snap custom Brave ad notifications to the edge of the screen #17527

tmancey opened this issue Aug 17, 2021 · 1 comment · Fixed by brave/brave-core#10018
Assignees
@aseren
Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.32.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Aug 17, 2021

  • Snap custom Brave ad notifications to the edge of the screen when
    • dragging
    • to the closest monitor when removing a display
    • changing resolution
@aseren aseren self-assigned this Sep 7, 2021
aseren added a commit to brave/brave-core that referenced this issue Sep 9, 2021
@aseren
Snap custom ad notification to the screen edge.
a4d8d9c 
fix brave/brave-browser#17527
@aseren aseren mentioned this issue Sep 9, 2021
Merged
24 tasks
@tmancey tmancey added QA/Yes release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. labels Sep 15, 2021
aseren added a commit to brave/brave-core that referenced this issue Sep 17, 2021
@aseren
Snap custom ad notification to the screen edge.
1a6cb0e 
fix brave/brave-browser#17527
aseren added a commit to brave/brave-core that referenced this issue Sep 17, 2021
@aseren
Add test for custom ad notification snap.
aaf733e 
fix brave/brave-browser#17527
@tmancey tmancey added this to the 1.32.x - Nightly milestone Sep 17, 2021
@stephendonner
Copy link

stephendonner commented Nov 1, 2021 •
edited by btlechowski
Loading

Verified PASSED using

Brave 1.32.84 Chromium: 95.0.4638.54 (Official Build) beta (x86_64)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS macOS Version 11.6.1 (Build 20G224)

Case 1: dragging custom-ad notification

Steps:

  1. new profile
  2. launched Brave
  3. via brave://flags, enabled custom ads
  4. restarted
  5. enabled Rewards
  6. waited for an ad
  7. once custom-ad notification appeared, started dragging it to various screen positions
example example example example example
Screen Shot 2021-11-01 at 1 08 52 PM Screen Shot 2021-11-01 at 1 10 45 PM Screen Shot 2021-11-01 at 1 10 53 PM Screen Shot 2021-11-01 at 1 11 00 PM Screen Shot 2021-11-01 at 1 11 12 PM

Case 2: changing screen resolution

Steps:

  1. new profile
  2. launched Brave
  3. via brave://flags, enabled custom ads
  4. restarted
  5. enabled Rewards
  6. opened System Preferences -> Displays - chose Scaled
  7. changed resolution while custom ad was displayed
example example example
Screen Shot 2021-11-01 at 1 11 33 PM Screen Shot 2021-11-01 at 1 11 40 PM Screen Shot 2021-11-01 at 1 11 52 PM

Case 3: removing monitor

Steps:

  1. hooked up 2nd monitor
  2. new profile
  3. launched Brave
  4. via brave://flags, enabled custom ads
  5. restarted
  6. enabled Rewards
  7. waited for ads
  8. when a custom ad notification appeared, I dragged it to the 2nd monitor
  9. disconnected the 2nd monitor and confirmed it snapped to the top-right of the screen, near the browser
1st monitor 2nd monitor 2nd monitor 1st monitor; 2nd monitor removed
Screen Shot 2021-11-01 at 1 55 32 PM Screen Shot 2021-11-01 at 1 55 19 PM Screen Shot 2021-11-01 at 1 55 44 PM Screen Shot 2021-11-01 at 1 55 58 PM

Verification PASSED


Brave | 1.32.88 Chromium: 95.0.4638.69 (Official Build) beta (64-bit)
-- | --
Revision | 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS | Windows 10 Version 21H1 (Build 19043.1288)
Case 1: dragging custom-ad notification

Steps:

  1. new profile
  2. launched Brave
  3. via brave://flags, enabled custom ads
  4. restarted
  5. enabled Rewards
  6. waited for an ad
  7. once custom-ad notification appeared, started dragging it to various screen positions
example example example example example
image image image image image
Case 2: changing screen resolution

Steps:

  1. new profile
  2. launched Brave
  3. via brave://flags, enabled custom ads
  4. restarted
  5. enabled Rewards
  6. changed resolution to 125%, 100% and 150% while custom ad was displayed
example example example
image image image
Case 3: removing external display

Steps:

  1. hooked up 2nd monitor
  2. new profile
  3. launched Brave
  4. via brave://flags, enabled custom ads
  5. restarted
  6. enabled Rewards
  7. waited for ads
  8. when a custom ad notification appeared, I dragged it to the 2nd monitor
  9. disconnected the 2nd monitor and confirmed it snapped to the top-right of the screen, near the browser

Filed #19210

Verification passed on

Brave 1.32.90 Chromium: 95.0.4638.69 (Official Build) beta (64-bit)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS Ubuntu 18.04 LTS
Case 1: dragging custom-ad notification in multi monitor setup
1-1 1-2 1-3 1-4 1-5 1-6
Case 2: changing screen resolution
3-1 3-2
Case 3: removing external display
2-1 2-2

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.32.x - Release
Development

Successfully merging a pull request may close this issue.

Snap custom ad notification to the screen edge. brave/brave-core
4 participants
@stephendonner @tmancey @btlechowski @aseren