Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom-ad notification appears tiny after disconnecting external display/monitor #19210

Closed
stephendonner opened this issue Nov 3, 2021 · 2 comments · Fixed by brave/brave-core#11467

Comments

@stephendonner
Copy link

stephendonner commented Nov 3, 2021

Description

Custom-ad notification appears tiny after disconnecting external display/monitor

Steps to Reproduce

  1. hook up 2nd display to primary computer
  2. new profile
  3. launch Brave
  4. enable Custom Ad Notifications via brave://flags
  5. restart Brave
  6. enable Rewards
  7. wait for ads
  8. when a custom-ad notification appears, drag it to the 2nd, external display
  9. now, disconnect the 2nd, external display
  10. look at the custom-ad notification's size

Actual result:

The custom-ad notification appears tiny, and looks to be blank. Clicking and dragging it resizes it back to its correct size.

monitor-removed

settings 1 settings 2 settings 3 (laptop) settings 4 (external display)
settings settings2 settings3 settings4

Expected result:

expected

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.32.90 Chromium: 95.0.4638.69 (Official Build) beta (64-bit)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS Windows 10 Version 20H2 (Build 19042.1288)
@stephendonner
Copy link
Author

stephendonner commented Dec 24, 2021

Verified PASSED using

Brave 1.35.59 Chromium: 97.0.4692.56 (Official Build) nightly (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Windows 10 Version 20H2 (Build 19042.1415)

Used the original steps to reproduce, and confirmed the ad was correctly sized when disconnecting the 2nd display monitor.

Commandline used (to let me drag the ad notification from window to window):

brave.exe --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --brave-today-host=brave-today-cdn.bravesoftware.com --variations-server-url=https://no-thanks.invalid --enable-features="AdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:should_support_multiple_displays/true"
example example example
19210-1 19210-2 19210-3

Verification passed on

Brave 1.35.85 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Ubuntu 20

Used the original steps to reproduce, and confirmed the ad was correctly sized when disconnecting the 2nd display monitor.

Commandline used (to let me drag the ad notification from window to window):

brave.exe --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --brave-today-host=brave-today-cdn.bravesoftware.com --variations-server-url=https://no-thanks.invalid --enable-features="AdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:should_support_multiple_displays/true"
Screenshot from 2022-01-17 01-39-06 Screenshot from 2022-01-17 01-39-17

@stephendonner
Copy link
Author

stephendonner commented Jan 14, 2022

Verified PASSED using

Brave 1.35.85 Chromium: 97.0.4692.71 (Official Build) beta (x86_64)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS macOS Version 11.6.1 (Build 20G224)

Followed my original steps to reproduce, and confirmed that the custom-ad notification was correctly sized, after disconnecting the 2nd monitor.

Commandline used:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true --brave-today-host=brave-today-cdn.bravesoftware.com --variations-server-url=https://no-thanks.invalid --enable-features="AdNotifications<CommandLineStudy" --force-fieldtrials="CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:should_support_multiple_displays/true"
example example example example
Screen Shot 2022-01-14 at 10 24 10 AM Screen Shot 2022-01-14 at 10 37 16 AM Screen Shot 2022-01-14 at 10 37 41 AM Screen Shot 2022-01-14 at 10 38 06 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment