Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix popup bounds recompute on monitor scale change. #11467

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Dec 7, 2021

Bounds are calculated basing on view size which is evaluated during AdNotificationView::OnDeviceScaleFactorChanged() event.

Resolves brave/brave-browser#19210

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Test case 1

  1. launch Brave
  2. enable Custom Ad Notifications via brave://flags
  3. restart Brave
  4. enable Rewards
  5. wait for ads
  6. when a custom-ad notification appears, change displace scale
  7. custom-ad notification should be redrawn properly

Test case 2

  1. hook up 2nd display to primary computer
  2. in settings make 2nd display as primary display
  3. launch Brave
  4. enable Custom Ad Notifications via brave://flags
  5. restart Brave
  6. enable Rewards
  7. wait for ads
  8. custom-ad notification should appear on 2nd display as it is primary one
  9. now, disconnect the 2nd, external display
  10. custom-ad notification should be redrawn properly

Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aseren aseren merged commit ce6de9a into master Dec 9, 2021
@aseren aseren deleted the issues/19210 branch December 9, 2021 14:22
@tmancey tmancey added this to the 1.35.x - Nightly milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom-ad notification appears tiny after disconnecting external display/monitor
2 participants