Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more hover states to Rewards Panel UI 2.0 #17974

Closed
Miyayes opened this issue Sep 9, 2021 · 2 comments · Fixed by brave/brave-core#10181
Closed

Add more hover states to Rewards Panel UI 2.0 #17974

Miyayes opened this issue Sep 9, 2021 · 2 comments · Fixed by brave/brave-core#10181
Assignees
@zenparsing
Labels
feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude rewards-2.0
Milestone
1.31.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Sep 9, 2021

Description

  • Send Tip
  • Verify wallet

Currently do not have hover states in the Rewards Panel 2.0 design. We should consider adding hover states to make everything feel more reactive and clickable in UX.

image
@Miyayes Miyayes added design A design change, especially one which needs input from the design team feature/rewards design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Desktop rewards-2.0 labels Sep 9, 2021
@Miyayes Miyayes assigned ghost Sep 9, 2021
@zenparsing zenparsing self-assigned this Sep 9, 2021
@zenparsing zenparsing mentioned this issue Sep 21, 2021
Merged
24 tasks
@zenparsing zenparsing added this to the 1.31.x - Beta milestone Sep 22, 2021
@zenparsing zenparsing added QA/Yes release-notes/exclude and removed design A design change, especially one which needs input from the design team design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Sep 22, 2021
@brave-builds brave-builds mentioned this issue Sep 23, 2021
Merged
7 tasks
@LaurenWags
Copy link
Member

labelling QA/Blocked until uplift to 1.31.x is completed

@LaurenWags
Copy link
Member

LaurenWags commented Oct 4, 2021 •
edited by stephendonner
Loading

Verified passed with

Brave | 1.31.70 Chromium: 94.0.4606.71 (Official Build) beta (x86_64)
-- | --
Revision | 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS | macOS Version 10.15.7 (Build 19H1417)

See testing notes under #18341 (comment)

Verification passed on

Brave | 1.31.71 Chromium: 94.0.4606.71 (Official Build) beta (64-bit)
-- | --
Revision | 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS | Windows 10 Version 21H1 (Build 19043.1237)

Testing notes are available in #17941 (comment)

Verification PASSED using

Brave 1.31.84 Chromium: 95.0.4638.40 (Official Build) (64-bit)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS Linux

Testing notes are available in #18341 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude rewards-2.0
Projects
None yet
Milestone
1.31.x - Release
Development

Successfully merging a pull request may close this issue.

Add pending publisher hover messages to Rewards panel brave/brave-core
6 participants
@stephendonner @kjozwiak @zenparsing @Miyayes @LaurenWags @GeetaSarvadnya