Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending publisher hover messages to Rewards panel #10181

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Sep 21, 2021

Resolves brave/brave-browser#17974
Resolves brave/brave-browser#18153
Resolves brave/brave-browser#17941

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Message 1: "This creator is not signed up yet. Any tip you make will remain pending in your wallet and retry automatically for 90 days. Learn more."

Message 2: "This creator is currently not configured to receive tips from your wallet. Any tip you make will remain pending in your wallet and retry automatically for 90 days. Learn more."

Case 1: Not registered

Example staging creator: apple.com

  • Given that the user has enabled rewards
  • When the user navigates to a publisher page
  • And the publisher is not a registered creator
  • Then the Rewards panel publisher status indicator should display message 1 on hover.

Case 2: Registered but not verified

Example staging creator: www.reddit.com/user/jsadler-brave

  • Given that the user has enabled rewards
  • When the user navigates to a publisher page
  • And the publisher is a registered creator
  • And the publisher is not verified with any wallet provider
  • Then the Rewards panel publisher status indicator should display message 2 on hover.

Case 3: Verified and user is not connected

Example staging creator: laurenwags.github.io

  • Given that the user has enabled rewards
  • And has not connected to an external wallet provider
  • When the user navigates to a publisher page
  • And the publisher is verified with any wallet provider
  • Then the Rewards panel publisher status indicator should not display a message on hover

Case 4: Verified with non-matching wallet provider

  • Given that the user has enabled rewards
  • And has connected to an external wallet provider
  • When the user navigates to a publisher page
  • And the publisher is verified with a different wallet provider
  • Then the Rewards panel publisher status indicator should display message 2 on hover.

Case 5: Verified with matching wallet provider

  • Given that the user has enabled rewards
  • And has connected to an external wallet provider
  • When the user navigates to a publisher page
  • And the publisher is verified with the same wallet provider
  • Then the Rewards panel publisher status indicator should not display a message on hover.

@zenparsing zenparsing requested a review from a team as a code owner September 21, 2021 20:34
@zenparsing zenparsing requested review from jumde and emerick September 21, 2021 20:34
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing force-pushed the ksmith-rewards-panel-notes branch from b1089af to 73b3c6c Compare September 21, 2021 21:17
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 27, 2021

Verification passed on


Brave | 1.32.16 Chromium: 94.0.4606.54 (Official Build) nightly (64-bit)
-- | --
Revision | c8191a1d5cccbf64e8fe7269043f8ace8d74dd05-refs/branch-heads/4606@{#1130}
OS | Windows 10 Version 21H1 (Build 19043.1237)

Case 1: Not registered

Clean profile

  • Confirmed mouse hover on publisher status indicator shows the new message for unverified pubs
    "This creator is not signed up yet. Any tip you make will remain pending in your wallet and retry automatically for 90 days. Learn more."
  • Attempt to tip an unverified publisher, confirmed this publisher shows the messaging on panel/tip banners that indicate they are not verified.
  • Confirmed tips (one-time/recurring) sent to unverified pubs are displayed under the pending contributions table
  • Confirmed click on See all displays the pending contributions table
  • Confirmed pending contributions BAT amount is displayed in the rewards settings summary page.
BR panel Tipping banner Summary Pending contributions
image image image image

Upgrade profile

  • Install 1.29.x nightly build, enable rewards and claim UGP grants and send one-time and recurring tips to unverified pubs, upgrade the profile to 1.32.x nightly build
  • Confirmed publisher shows the new messaging on panel/tip banners that indicate they are not verified after upgrade
  • Confirmed pending contributions BAT is shown correctly in the rewards settings summary section after the upgrade
  • Confirmed unverified pubs are displayed under the Pending contributions table after the upgrade

1.29.x (old message on BR panel and tipping banner)

Example Example Example Example
image image image image

After upgrade to 1.32.x (new message display on BR panel and tipping banner)

Example Example Example Example
image image image image
Case 2: Registered but not verified

Clean profile

  • Confirmed mouse hover on publisher status indicator shows the new message for registered user (registered but not verified with any wallet provider) "This creator is currently not configured to receive tips from your wallet. Any tip you make will remain pending in your wallet and retry automatically for 90 days. Learn more."
  • Confirmed new message Verified creator with a checkmark is shown in the BR panel
  • Attempt to tip connected pubs, but not KYC'd publisher, confirmed this publisher shows messaging on panel/banners indicating they cannot accept tips.
  • Confirmed one-time/recurring tips are processed successfully and rewards balance is shown correctly
  • Confirmed tips are shown correctly in Tips panel, summary and monthly statement
Example Example Example Example Example
image image image image image

Upgrade profile

  • Install 1.30.x nightly build, enable rewards and claim UGP grants and send one-time and recurring tips to registered pubs (registered but not verified with any wallet provider), upgrade the profile to 1.32.x nightly build
  • Confirmed new message is shown in the BR panel as well as in the tipping banner after upgrade

1.30.x (old message on BR panel and tipping banner)

Example Example Example
image image image

After upgrade to 1.32.x (new message on BR panel and tipping banner)

Example Example Example
image image image
Brave | 1.32.20 Chromium: 94.0.4606.54 (Official Build) nightly (64-bit)
-- | --
Revision | c8191a1d5cccbf64e8fe7269043f8ace8d74dd05-refs/branch-heads/4606@{#1130}
OS | Windows 10 Version 21H1 (Build 19043.1237)

Case 3: Verified and user is not connected

Clean profile

  • Confirmed mouse hover on publisher status indicator doesn't show any message on the BR panel
  • Attempt to tip a verified publisher, confirmed this publisher does not show any messaging on panel/banners indicating they cannot accept tips.
  • Confirmed new message Verified creator with a checkmark is shown in the BR panel
Example Example Example
image image image

Upgrade profile

  • Install 1.30.x nightly build, enable rewards and claim UGP grants and send one-time or recurring tips to verified pubs and then upgrade the profile to 1.32.x nightly build
  • Confirmed updated message Verified creator with a checkmark is shown in the BR panel after the upgrade
  • Confirmed correct message is shown in the tipping banner

1.30.x (old message on BR panel and tipping banner)

Example Example Example
image image image

1.32.x (new message on BR panel and tipping banner)

Example Example Example
image image image
Case 4: Verified with non-matching wallet provider

1. Publisher is NOT verified with uphold (batcommunity.org)

Clean profile

  • Confirmed mouse hover on publisher status indicator shows the message as "This creator is currently not configured to receive tips from your wallet. Any tip you make will remain pending in your wallet and retry automatically for 90 days. Learn more."
  • Confirmed new message Verified creator with a checkmark is shown in the BR panel
  • Attempt to tip a connected, but not KYC'd publisher. Confirm this publisher shows messaging on panel/banners indicating they cannot accept tips.
  • Confirmed one-time/recurring tips sent to batcommunity.org are displayed under pending contribution table
  • Confirmed wallet balance is not deducted
  • Confirmed pending Tips are shown in the Rewards summary section (pending contribution table)
Example Example Example Example
image image image image

Upgrade profile

  • Install 1.30.x nightly build, enable rewards and connect KYC'd uphold wallet and send one-time and recurring tips to batcommunity.org publisher and upgrade the profile to 1.32.x nightly build
  • Confirmed new message is shown in the BR panel as well as in the tipping banner after the upgrade
  • Confirmed pending Tips are shown in the Rewards summary section after the upgrade
  • Confirmed pending tips are displayed under the pending contribution table after the upgrade
    1.30.x (old message on BR panel and tipping banner)
Example Example Example
image image image

After upgrade to1.32.x (new message on BR panel and tipping banner)

Example Example Example
image image image

2. Publisher is NOT verified with Gemini (laurenwags.github.io)

Clean profile

  • Confirmed mouse hover on publisher status indicator shows the message as "This creator is currently not configured to receive tips from your wallet. Any tip you make will remain pending in your wallet and retry automatically for 90 days. Learn more."
  • Confirmed new message Verified creator with a checkmark is shown in the BR panel
  • Attempt to tip a connected, but not KYC'd publisher. Confirm this publisher shows messaging on panel/banners indicating they cannot accept tips.
  • Confirmed one-time/recurring tips sent to batcommunity.org are displayed under pending contribution table
  • Confirmed wallet balance is not deducted
  • Confirmed pending Tips are shown in the Rewards summary section (pending contribution table)
Example Example Example Example
image image image image

Upgrade profile

  • Install 1.30.x nightly build, enable rewards and connect KYC'd uphold wallet and send one-time and recurring tips to batcommunity.org publisher and upgrade the profile to 1.32.x nightly build
  • Confirmed new message is shown in the BR panel as well as in the tipping banner after the upgrade
  • Confirmed pending Tips are shown in the Rewards summary section after the upgrade
  • Confirmed pending tips are displayed under the pending contribution table after the upgrade
    1.30.x (old message on BR panel and tipping banner)
Example Example Example Example
image image image image

After upgrade 1.32.x (new message on BR panel and tipping banner)

Example Example Example
image image image
Case 5: Verified with matching wallet provider

1. Publisher is verified with uphold (laurenwags.github.io)

  • Confirmed mouse hover on publisher status indicator doesn't show any message on the BR panel
  • Confirmed new message Verified creator with a checkmark is shown in the BR panel
  • Attempt to tip a KYC'd uphold publisher, confirmed this publisher does not show any messaging on panel/banners indicating they cannot accept tips.
  • Confirmed One-time, recurring tips and AC is processed successfully
Example Example Example
image image image

2. Publisher is verified with Gemini (batcommunity.org)

  • Confirmed mouse hover on publisher status indicator doesn't show any message on the BR panel
  • Confirmed new message Verified creator with a checkmark is shown in the BR panel
  • Attempt to tip a KYC'd gemini publisher, confirmed this publisher does not show any messaging on panel/banners indicating they cannot accept tips.
  • Confirmed One-time, recurring tips and AC is processed successfully
Example Example Example Example
image image image image
Case 6: Publisher message verification for Japan region

1. KYC'd bitfley publisher

  1. Attempt to tip a KYC'd bitflyer publisher, confirmed this publisher does not show any messaging on panel/banners indicating they cannot accept tips.
  2. Confirmed Tips are processed successfully, confirmeded tip is deducted from balance and shows in "Tips" on brave://rewards. Confirm the tip shows on the Contributions page of brave://rewards-internals.
Example Example Example Example Example
image image image image image

2. Connected pubs

  1. Attempt to tip a connected, but not KYC'd publisher. Confirm this publisher shows messaging on panel/banners indicating they cannot accept tips.
  2. Confirm tip goes to "Pending" list, is not deducted from balance, and does not show in "Tips" on brave://rewards
    Attempt to tip a KYC'd Uphold publisher. Confirm this publisher shows messaging on panel/banners indicating they cannot accept tips.
  3. Confirm tip goes to "Pending" list, is not deducted from balance, and does not show in "Tips" on brave://rewards
Example Example Example Example
image image image image

3. Unverified pubs

  1. Attempt to tip an unverified publisher. Confirm this publisher shows the messaging on panel/tip banners that indicate they are not verified.
  2. Confirm tip goes to "Pending" list, is not deducted from the balance, and does not show in "Tips" on brave://rewards
Example Example Example Example
image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants