-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pending publisher hover messages to Rewards panel #10181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b1089af
to
73b3c6c
Compare
Verification passed on
Case 1: Not registeredClean profile
Upgrade profile
After upgrade to
Case 2: Registered but not verifiedClean profile
Upgrade profile
After upgrade to
Case 3: Verified and user is not connectedClean profile
Upgrade profile
Case 4: Verified with non-matching wallet provider1. Publisher is NOT verified with uphold (batcommunity.org) Clean profile
Upgrade profile
After upgrade to
2. Publisher is NOT verified with Gemini (laurenwags.github.io) Clean profile
Upgrade profile
After upgrade
Case 5: Verified with matching wallet provider1. Publisher is verified with uphold (laurenwags.github.io)
2. Publisher is verified with Gemini (batcommunity.org)
Case 6: Publisher message verification for Japan region1. KYC'd bitfley publisher
2. Connected pubs
3. Unverified pubs
|
Resolves brave/brave-browser#17974
Resolves brave/brave-browser#18153
Resolves brave/brave-browser#17941
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Message 1: "This creator is not signed up yet. Any tip you make will remain pending in your wallet and retry automatically for 90 days. Learn more."
Message 2: "This creator is currently not configured to receive tips from your wallet. Any tip you make will remain pending in your wallet and retry automatically for 90 days. Learn more."
Case 1: Not registered
Example staging creator:
apple.com
Case 2: Registered but not verified
Example staging creator:
www.reddit.com/user/jsadler-brave
Case 3: Verified and user is not connected
Example staging creator:
laurenwags.github.io
Case 4: Verified with non-matching wallet provider
Case 5: Verified with matching wallet provider