Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publisher status hover note to Rewards panel #17941

Closed
zenparsing opened this issue Sep 8, 2021 · 3 comments · Fixed by brave/brave-core#10181
Closed

Add publisher status hover note to Rewards panel #17941

zenparsing opened this issue Sep 8, 2021 · 3 comments · Fixed by brave/brave-core#10181

Comments

@zenparsing
Copy link

If the displayed publisher is unverified, or their verified account does not match the user's external wallet type (for users that have connected an external wallet), then display a hover note with an explanation.

Screen Shot 2021-09-08 at 11 39 22 AM

@stephendonner
Copy link

stephendonner commented Sep 27, 2021

Setting QA/Blocked until brave/brave-core#10224 is merged in to 1.31.x

@kjozwiak
Copy link
Member

Removing QA/Blocked as brave/brave-core#10181 was uplifted into 1.31.x via brave/brave-core#10224.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 4, 2021

Verification passed on


Brave | 1.31.67 Chromium: 94.0.4606.61 (Official Build) beta (64-bit)
-- | --
Revision | 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS | Windows 10 Version 21H1 (Build 19043.1237)

Case 1: Not registered
  • Confirmed mouse hover on publisher status indicator shows the new message for unverified pubs
    "This creator is not signed up yet. Any tip you make will remain pending in your wallet and retry automatically for 90 days. Learn more."
  • Attempt to tip an unverified publisher, confirmed this publisher shows the messaging on panel/tip banners that indicate they are not verified.
  • Confirmed tips (one-time/recurring) sent to unverified pubs are displayed under the pending contributions table
  • Confirmed click on See all displays the pending contributions table
  • Confirmed pending contributions BAT amount is displayed in the rewards settings summary page.
BR panel Tipping banner Summary Pending contributions
image image image image
Case 2.1 : Registered but not verified with any wallet provider
  • Confirmed mouse hover on publisher status indicator shows the message as This creator is currently not configured to receive tips from your wallet. Any tip you make will remain pending in your wallet and retry automatically for 90 days. Learn more.
  • Confirmed new message Verified creator with a checkmark is shown in the BR panel
  • Attempt to tip a verified pub, confirmed this publisher shows messaging on panel/banners indicating they cannot accept tips.
  • Confirmed one-time/recurring tips are NOT processed and rewards balance is not deducted
  • Confirmed pending tips are shown correctly in summary and pending contribution table
Example Example Example Example
image image image image
Case 2.2 : Registered but not connected to any externals wallets
  • Confirmed mouse hover on publisher status indicator doesn't show any message on BR panel/tipping banner
  • Confirmed new message Verified creator with a checkmark is shown in the BR panel
  • Attempt to tip verified pubs, confirmed this publisher doesn't show any message on panel/banners
  • Confirmed one-time/recurring tips are processed successfully and rewards balance is shown correctly
  • Confirmed tips processed are shown correctly in the Tips panel, summary, and monthly statement
Example Example Example Example
image image image image
Case 3: Verified and user is not connected
  • Confirmed mouse hover on publisher status indicator doesn't show any message on the BR panel
  • Attempt to tip a verified publisher, confirmed this publisher does not show any messaging on panel/banners indicating they cannot accept tips.
  • Confirmed new message Verified creator with a checkmark is shown in the BR panel
Example Example Example Example
image image image image
Case 4: Verified with non-matching wallet provider

1. Publisher is NOT verified with uphold (batcommunity.org)

  • Confirmed mouse hover on publisher status indicator shows the message as "This creator is currently not configured to receive tips from your wallet. Any tip you make will remain pending in your wallet and retry automatically for 90 days. Learn more."
  • Confirmed new message Verified creator with a checkmark is shown in the BR panel
  • Attempt to tip a connected, but not KYC'd publisher. Confirm this publisher shows messaging on panel/banners indicating they cannot accept tips.
  • Confirmed one-time/recurring tips sent to batcommunity.org are displayed under pending contribution table
  • Confirmed wallet balance is not deducted
  • Confirmed pending Tips are shown in the Rewards summary section (pending contribution table)
Example Example Example Example
image image image image

2. Publisher is NOT verified with Gemini (laurenwags.github.io)

  • Confirmed mouse hover on publisher status indicator shows the message as "This creator is currently not configured to receive tips from your wallet. Any tip you make will remain pending in your wallet and retry automatically for 90 days. Learn more."
  • Confirmed new message Verified creator with a checkmark is shown in the BR panel
  • Attempt to tip a connected, but not KYC'd publisher. Confirm this publisher shows messaging on panel/banners indicating they cannot accept tips.
  • Confirmed one-time/recurring tips sent to batcommunity.org are displayed under pending contribution table
  • Confirmed wallet balance is not deducted
  • Confirmed pending Tips are shown in the Rewards summary section (pending contribution table)
Example Example Example Example
image image image image
Case 5: Verified with matching wallet provider

1. Publisher is verified with uphold (laurenwags.github.io)

  • Confirmed mouse hover on publisher status indicator doesn't show any message on the BR panel
  • Confirmed new message Verified creator with a checkmark is shown in the BR panel
  • Attempt to tip a KYC'd uphold publisher, confirmed this publisher does not show any messaging on panel/banners indicating they cannot accept tips.
  • Confirmed One-time, recurring tips and AC is processed successfully
Example Example Example Example
image image image image

2. Publisher is verified with Gemini (batcommunity.org)

  • Confirmed mouse hover on publisher status indicator doesn't show any message on the BR panel
  • Confirmed new message Verified creator with a checkmark is shown in the BR panel
  • Attempt to tip a KYC'd gemini publisher, confirmed this publisher does not show any messaging on panel/banners indicating they cannot accept tips.
  • Confirmed One-time, recurring tips and AC is processed successfully
Example Example Example Example Example
image image image image image
Case 6: Bitflyer wallet (funded via Bitflyer BAT on staging env)

1. KYC'd bitfley publisher

  1. Attempt to tip a KYC'd bitflyer publisher, confirmed this publisher does not show any messaging on panel/banners indicating they cannot accept tips.
  2. Confirmed Tips are processed successfully, confirmeded tip is deducted from balance and shows in "Tips" on brave://rewards. Confirm the tip shows on the Contributions page of brave://rewards-internals.
Example Example Example Example Example
image image image image image

2. Connected pubs

  1. Attempt to tip a connected, but not KYC'd publisher. Confirm this publisher shows messaging on panel/banners indicating they cannot accept tips.
  2. Confirm tip goes to "Pending" list, is not deducted from balance, and does not show in "Tips" on brave://rewards
    Attempt to tip a KYC'd Uphold publisher. Confirm this publisher shows messaging on panel/banners indicating they cannot accept tips.
  3. Confirm tip goes to "Pending" list, is not deducted from balance, and does not show in "Tips" on brave://rewards
Example Example Example Example
image image image image

3. Unverified pubs

  1. Attempt to tip an unverified publisher. Confirm this publisher shows the messaging on panel/tip banners that indicate they are not verified.
  2. Confirm tip goes to "Pending" list, is not deducted from the balance, and does not show in "Tips" on brave://rewards
Example Example Example Example
image image image image
Anon wallet (funded via UGP grant)

Confirmed tip to unverified creator went to pending list and appropriate message (1) was displayed:

Example Example Example Example
image image image image

Confirmed able to tip connected, Uphold, Gemini, and bitFlyer KYC'd creators and no messaging was displayed.
Confirmed balance decreased as expected for tip to each of these creators.

connected example connected example uphold example uphold example gemini example gemini example bitflyer example bitflyer example
image image image image image image image image
Uphold wallet (funded via Uphold BAT on staging env)

Confirmed tip to unverified creator went to pending list and appropriate message (1) was displayed:

Example Example Example Example
image image image image

Confirmed tip to connected, Gemini, and bitFlyer creators went to pending list and appropriate message (2) was displayed:

Example Example Example Example Example Example Example Example
image image image image image image image image

Confirmed able to tip Uphold KYC'd creator and no messaging was displayed.
Confirmed balance decreased as expected for tip.

Example Example Example Example
image image image image
Gemini wallet (funded via Gemini BAT on staging env)

Confirmed tip to unverified creator went to pending list and appropriate message (1) was displayed:

Example Example Example Example
image image image image

Confirmed tip to connected, bitFlyer, and Uphold creators went to pending list and appropriate message (2) was displayed:

Connected Example Connected Example bitFlyer Example bitFlyer Example Uphold Example Uphold Example Wallet Panel Pending Tips List
image image image image image image image image

Confirmed able to tip Gemini KYC'd creator and no messaging was displayed.
Confirmed balance decreased as expected for tip.

Example Example Example Example
image image image image
----------------

Verified passed with

Brave | 1.31.70 Chromium: 94.0.4606.71 (Official Build) beta (x86_64)
-- | --
Revision | 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS | macOS Version 10.15.7 (Build 19H1417)

See testing notes under #18341 (comment)


Verified PASSED using

Brave 1.31.81 Chromium: 95.0.4638.40 (Official Build) beta (64-bit)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS Linux

See testing notes at #18341 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment