-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Rewards panel 2.0 #9883
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenparsing
force-pushed
the
ksmith-rewards-panel-integration
branch
4 times, most recently
from
September 1, 2021 20:18
fe17082
to
ab0c3c1
Compare
zenparsing
force-pushed
the
ksmith-rewards-panel-integration
branch
from
September 1, 2021 21:15
ab0c3c1
to
0da5b0a
Compare
zenparsing
force-pushed
the
ksmith-rewards-panel-integration
branch
from
September 2, 2021 17:41
0da5b0a
to
012cad7
Compare
zenparsing
force-pushed
the
ksmith-rewards-panel-integration
branch
from
September 2, 2021 17:46
012cad7
to
05a6464
Compare
emerick
reviewed
Sep 3, 2021
components/brave_rewards/browser/test/rewards_contribution_browsertest.cc
Show resolved
Hide resolved
components/brave_rewards/resources/extension/brave_rewards/_locales/en_US/messages.json
Show resolved
Hide resolved
zenparsing
force-pushed
the
ksmith-rewards-panel-integration
branch
from
September 3, 2021 18:48
05a6464
to
f41dcb2
Compare
emerick
approved these changes
Sep 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zenparsing
force-pushed
the
ksmith-rewards-panel-integration
branch
2 times, most recently
from
September 7, 2021 15:48
40808f2
to
0bd6f5d
Compare
zenparsing
force-pushed
the
ksmith-rewards-panel-integration
branch
from
September 7, 2021 19:00
0bd6f5d
to
58de26b
Compare
szilardszaloki
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#14602
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Figma: https://www.figma.com/file/p4F6ItJQVeKPeFQhjoaPGm/BR-panel-2.0?node-id=1170%3A35310
Functional differences from previous UI
Test cases: Rewards Panel
Test cases: Rewards Page