Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tipping banner warning text for unverified creator versus no available path creators #18137

Closed
Miyayes opened this issue Sep 15, 2021 · 1 comment · Fixed by brave/brave-core#10137
Assignees

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Sep 15, 2021

Description

There are two kinds of reasons why a tip will go into a pending state (i.e., the tip will be put into the pending list, and retry for 90 days):

  1. TYPE 1: The creator is unverified. When the creator is unverified, they cannot receive tips from any users, and all tips from all possible users will go into pending)
  2. TYPE 2: No available path from user to creator. The creator is "verified" (blue checkmark), but (a) the creator does not have a custodian that matches the user's custodian, OR (b) the creator does not have a custodian at all. (Edit: Assumption is that the user is verified. If the user is unverified, then as long as the creator has a blue checkmark, they'll be able to tip/a path exists from user to creator.)

Our error messages need to reflect the above two cases properly. For example, below is a case of TYPE 1, but the messaging reflects TYPE 2:

image

Solution

TYPE 1 TEXT

This creator is not signed up yet. Any tip you make will remain pending in your wallet and retry automatically for 90 days. Learn more.

TYPE 2 TEXT

This creator is currently not configured to receive tips from your wallet. Any tip you make will remain pending in your wallet and retry automatically for 90 days. Learn more.

cc: @kjozwiak

@LaurenWags
Copy link
Member

LaurenWags commented Oct 4, 2021

Verified passed with

Brave | 1.31.70 Chromium: 94.0.4606.71 (Official Build) beta (x86_64)
-- | --
Revision | 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS | macOS Version 10.15.7 (Build 19H1417)

See testing notes under #18341 (comment)


Verification passed on

Brave | 1.31.71 Chromium: 94.0.4606.71 (Official Build) beta (64-bit)
-- | --
Revision | 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS | Windows 10 Version 21H1 (Build 19043.1237)

Testing notes are available in #17941 (comment)


Verified PASSED using

Brave 1.31.81 Chromium: 95.0.4638.40 (Official Build) beta (64-bit)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants