Show correct notice on tipping banner for unregistered creators #10137

zenparsing · 2021-09-17T15:45:57Z

Submitter Checklist:

I confirm that no security/privacy review is needed, or that I have requested one
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Message 1: "NOTE: This creator is not signed up yet. Any tip you make will remain pending in your wallet and retry automatically for 90 days. Learn more."

Message 2: "NOTE: This creator is currently not configured to receive tips from your wallet. Any tip you make will remain pending in your wallet and retry automatically for 90 days. Learn more."

Case 1: Not registered

Example staging creator: apple.com

Given that the user has enabled rewards
When the user navigates to a publisher page
And the publisher is not a registered creator
Then the tipping banner should display message 1.

Case 2: Registered but not verified

Example staging creator: www.reddit.com/user/jsadler-brave

Given that the user has enabled rewards
When the user navigates to a publisher page
And the publisher is a registered creator
And the publisher is not verified with any wallet provider
Then the tipping banner should display message 2.

Case 3: Verified and user is not connected

Example staging creator: laurenwags.github.io

Given that the user has enabled rewards
And has not connected to an external wallet provider
When the user navigates to a publisher page
And the publisher is verified with any wallet provider
Then the tipping banner should not display a message.

Case 4: Verified with non-matching wallet provider

Given that the user has enabled rewards
And has connected to an external wallet provider
When the user navigates to a publisher page
And the publisher is verified with a different wallet provider
Then the tipping banner should display message 2.

Case 5: Verified with matching wallet provider

Given that the user has enabled rewards
And has connected to an external wallet provider
When the user navigates to a publisher page
And the publisher is verified with the same wallet provider
Then the tipping banner should not display a message.

emerick

LGTM

szilardszaloki

We have yet another reference to siteBannerConnectedText in brave-browser\src\brave\.storybook\locale.ts.

LaurenWags · 2021-09-29T19:26:24Z

Verified using

Brave	1.32.31 Chromium: 94.0.4606.61 (Official Build) nightly (x86_64)
Revision	418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS	macOS Version 10.15.7 (Build 19H1417)

Verified test plan from #10137 (comment)

Scenario 1 - Not registered - PASSED

Confirmed message 1 is displayed on the tipping banner

Example	Example

Scenario 2 - Registered but not verified - Skipped, will be fixed with #10242

Scenario 3 - Verified and user is not connected - PASSED

Confirmed no message is displayed on the tipping banner

Example	Example

Brave | 1.32.33 Chromium: 94.0.4606.61 (Official Build) nightly (x86_64)
-- | --
Revision | 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS | macOS Version 10.15.7 (Build 19H1417)

Scenario 4 - Verified with non-matching wallet provider - PASSED

Confirmed message 2 is displayed on the tipping banner

Example	Example

Scenario 5 - Verified with matching wallet provider - PASSED

Confirmed no message is displayed on the tipping banner

Example	Example

Additional checks performed:

Anon wallet (funded via UGP grant) - PASSED

Confirmed tip to unverified creator went to pending list and appropriate message (1) was displayed:

Example	Example	Example	Example

Confirmed able to tip connected, Uphold, Gemini, and bitFlyer KYC'd creators and no messaging was displayed.
Confirmed balance decreased as expected for tip to each of these creators.

Connected Example	Connected Example	Uphold Example	Uphold Example	Gemini Example	Gemini Example	bitFlyer Example	bitFlyer Example	Tips List	Wallet Panel

Uphold wallet (funded via Uphold BAT on staging env) - PASSED

Confirmed tip to unverified creator went to pending list and appropriate message (1) was displayed:

Example	Example	Example	Example

Confirmed tip to connected, Gemini, and bitFlyer creators went to pending list and appropriate message (2) was displayed:

Connected Example	Connected Example	Gemini Example	Gemini Example	bitFlyer Example	bitFlyer Example	Wallet Panel	Pending Tips List

Confirmed able to tip Uphold KYC'd creator and no messaging was displayed.
Confirmed balance decreased as expected for tip.

Example	Example	Example	Example

bitFlyer wallet (funded via bitFlyer BAT on staging env) - PASSED

Confirmed tip to unverified creator went to pending list and appropriate message (1) was displayed:

Example	Example	Example	Example

Confirmed tip to connected, Gemini, and Uphold creators went to pending list and appropriate message (2) was displayed:

Connected Example	Connected Example	Gemini Example	Gemini Example	Uphold Example	Uphold Example	Wallet Panel	Pending Tips List

Confirmed able to tip bitFlyer KYC'd creator and no messaging was displayed.
Confirmed balance decreased as expected for tip.

Example	Example	Example	Example

Gemini wallet (funded via Gemini BAT on staging env) - PASSED

Confirmed tip to unverified creator went to pending list and appropriate message (1) was displayed:

Example	Example	Example	Example

Confirmed tip to connected, bitFlyer, and Uphold creators went to pending list and appropriate message (2) was displayed:

Connected Example	Connected Example	bitFlyer Example	bitFlyer Example	Uphold Example	Uphold Example	Wallet Panel	Pending Tips List

Confirmed able to tip Gemini KYC'd creator and no messaging was displayed.
Confirmed balance decreased as expected for tip.

Example	Example	Example	Example

zenparsing requested a review from a team as a code owner September 17, 2021 15:45

zenparsing requested review from bsclifton and szilardszaloki September 17, 2021 15:45

github-actions bot assigned zenparsing Sep 17, 2021

zenparsing force-pushed the ksmith-tip-banner-notice branch from 5b44a18 to a658387 Compare September 17, 2021 16:19

emerick approved these changes Sep 17, 2021

View reviewed changes

szilardszaloki approved these changes Sep 17, 2021

View reviewed changes

Show correct notice on tipping banner for pending creators

9417edd

zenparsing force-pushed the ksmith-tip-banner-notice branch from a658387 to 9417edd Compare September 21, 2021 15:15

emerick self-requested a review September 21, 2021 15:52

emerick approved these changes Sep 21, 2021

View reviewed changes

zenparsing merged commit be8ae6e into master Sep 21, 2021

zenparsing deleted the ksmith-tip-banner-notice branch September 21, 2021 19:31

brave-builds pushed a commit that referenced this pull request Sep 23, 2021

Uplift of #10137 (squashed) to beta

4d4a8da

brave-builds mentioned this pull request Sep 23, 2021

Show correct notice on tipping banner for unregistered creators (uplift to 1.31.x) #10223

Closed

7 tasks

zenparsing added this to the 1.32.x - Nightly milestone Sep 24, 2021

brave-builds pushed a commit that referenced this pull request Sep 27, 2021

Uplift of #10137 (squashed) to beta

22900ba

brave-builds mentioned this pull request Sep 27, 2021

Show correct notice on tipping banner for unregistered creators (uplift to 1.31.x) #10271

Merged

7 tasks

zenparsing pushed a commit that referenced this pull request Sep 29, 2021

Uplift of #10137 (squashed) to beta

09a1718

jonathansampson mentioned this pull request Nov 29, 2021

Even unverified creators shows as Brave Verified Creator brave/brave-browser#16570

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show correct notice on tipping banner for unregistered creators #10137

Show correct notice on tipping banner for unregistered creators #10137

zenparsing commented Sep 17, 2021 •

edited

Loading

emerick left a comment

szilardszaloki left a comment •

edited

Loading

LaurenWags commented Sep 29, 2021 •

edited

Loading

Show correct notice on tipping banner for unregistered creators #10137

Show correct notice on tipping banner for unregistered creators #10137

Conversation

zenparsing commented Sep 17, 2021 • edited Loading

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

Case 1: Not registered

Case 2: Registered but not verified

Case 3: Verified and user is not connected

Case 4: Verified with non-matching wallet provider

Case 5: Verified with matching wallet provider

emerick left a comment

Choose a reason for hiding this comment

szilardszaloki left a comment • edited Loading

Choose a reason for hiding this comment

LaurenWags commented Sep 29, 2021 • edited Loading

zenparsing commented Sep 17, 2021 •

edited

Loading

szilardszaloki left a comment •

edited

Loading

LaurenWags commented Sep 29, 2021 •

edited

Loading