Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date range on NTP Rewards widget v2 is incorrect #19691

Closed
LaurenWags opened this issue Nov 23, 2021 · 3 comments · Fixed by brave/brave-core#11252
Closed

date range on NTP Rewards widget v2 is incorrect #19691

LaurenWags opened this issue Nov 23, 2021 · 3 comments · Fixed by brave/brave-core#11252

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #17483.

For the month of Nov, date range is listed as Nov 1-Nov 29, but Nov has 30 days.

Steps to Reproduce

  1. Clean profile
  2. Enable Rewards
  3. Look at NTP widget

Actual result:

Date range says Nov 1 - Nov 29:

Screen Shot 2021-11-23 at 3 54 01 PM

Expected result:

Should say Nov 1 - Nov 30

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.33.87 Chromium: 96.0.4664.45 (Official Build) beta (x86_64)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS macOS Version 11.6.1 (Build 20G224)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @zenparsing @Miyayes @brave/legacy_qa

@LaurenWags
Copy link
Member Author

LaurenWags commented Nov 30, 2021

QA/Blocked until a new 1.33.x is built (1.33.96 or above)

@LaurenWags
Copy link
Member Author

Removing QA/Blocked, 1.33.98 is available.

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 3, 2021
@LaurenWags
Copy link
Member Author

Verified passed with

Brave | 1.33.99 Chromium: 96.0.4664.55 (Official Build) (x86_64)
-- | --
Revision | 38cededc5d09b785d12203f1d3209aa6eb293e79-refs/branch-heads/4664@{#1090}
OS | macOS Version 11.6.1 (Build 20G224)

Verified STR from #19691 (comment) for a few different months.
Confirmed date ranges were accurate on the widget.

December January February
Dec Jan Feb

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants