Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct month-end date for rewards NTP widget #11252

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Nov 23, 2021

Resolves brave/brave-browser#19691

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Rewards NTP Widget should show correct month start and end dates for the current month.

@zenparsing zenparsing requested a review from a team as a code owner November 23, 2021 21:21
@zenparsing zenparsing self-assigned this Nov 23, 2021
@zenparsing zenparsing force-pushed the ksmith-rewards-progress-range branch from 9dfdfe8 to aa84a92 Compare November 24, 2021 00:59
@zenparsing zenparsing force-pushed the ksmith-rewards-progress-range branch from aa84a92 to 04f24cf Compare November 24, 2021 01:03
@zenparsing zenparsing merged commit f1dc731 into master Nov 24, 2021
@zenparsing zenparsing deleted the ksmith-rewards-progress-range branch November 24, 2021 03:44
@zenparsing zenparsing added this to the 1.34.x - Nightly milestone Nov 24, 2021
brave-builds pushed a commit that referenced this pull request Nov 30, 2021
@LaurenWags
Copy link
Member

Verified using

Brave | 1.34.47 Chromium: 96.0.4664.45 (Official Build) nightly (x86_64)
-- | --
Revision | 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS | macOS Version 11.6.1 (Build 20G224)

Verified STR from brave/brave-browser#19691 (comment) for current month and upcoming month.
Confirmed date ranges were accurate on the widget.

November December
Nov Dec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

date range on NTP Rewards widget v2 is incorrect
3 participants