Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a description to all strings in Brave rewards en_US messages.json #2116

Closed
bbondy opened this issue Nov 13, 2018 · 0 comments · Fixed by brave/brave-core#905
Closed

Add a description to all strings in Brave rewards en_US messages.json #2116

bbondy opened this issue Nov 13, 2018 · 0 comments · Fixed by brave/brave-core#905
Assignees
@NejcZdovc
Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Milestone
0.57.x - Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Nov 13, 2018

Translators rely on descriptions to know the context of a string. Please add in descriptions for each string to give translators some context.
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 13, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Nov 13, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.57.x - Beta Nov 14, 2018
@NejcZdovc NejcZdovc mentioned this issue Nov 14, 2018
Merged
18 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 14, 2018
@NejcZdovc
Adds description to translations
cc4c5ff 
Resolves brave/brave-browser#2116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Milestone
0.57.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Adds description to translations brave/brave-core
3 participants
@bbondy @kjozwiak @NejcZdovc