Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds description to translations #905

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Adds description to translations #905

merged 1 commit into from
Nov 14, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Nov 14, 2018

Resolves brave/brave-browser#2116

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc self-assigned this Nov 14, 2018
@NejcZdovc NejcZdovc force-pushed the translation-desc branch 2 times, most recently from 1af1046 to d4c4b00 Compare November 14, 2018 06:47
@NejcZdovc NejcZdovc merged commit e9b8834 into master Nov 14, 2018
@NejcZdovc NejcZdovc deleted the translation-desc branch November 14, 2018 15:07
NejcZdovc added a commit that referenced this pull request Nov 14, 2018
Adds description to translations
@NejcZdovc
Copy link
Contributor Author

master (0.59) e9b8834
0.58.x 61d7f5b
0.57.x 7dc258d

NejcZdovc added a commit that referenced this pull request Nov 14, 2018
Adds description to translations
@bbondy bbondy added this to the 0.57.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a description to all strings in Brave rewards en_US messages.json
2 participants