Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a brave:// alias to match chrome:// #213

Closed
7 tasks done
bbondy opened this issue May 22, 2018 · 2 comments
Closed
7 tasks done

Support a brave:// alias to match chrome:// #213

bbondy opened this issue May 22, 2018 · 2 comments
Assignees
Labels

Comments

@bbondy
Copy link
Member

bbondy commented May 22, 2018

At the moment the brave:// will just forward to chrome://.
There was a working version of the other way around but it had a lot of patch files and was going to be hard to maintain so we went with this approach instead for now.

Should have similar brave:// links

Examples:

  • chrome://welcome/?variant=everywhere
  • chrome://downloads/
  • chrome://history/
  • chrome://bookmarks/
  • chrome://extensions/
  • chrome://chrome-urls/
  • chrome://apps (shortcut on bookmarks toolbar)
  • etc...
    image
@bbondy bbondy self-assigned this Jun 6, 2018
@bbondy bbondy added this to the Milestone 3: June-July milestone Jun 6, 2018
bbondy added a commit to brave/brave-core that referenced this issue Jun 12, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@bbondy
Copy link
Member Author

bbondy commented Aug 18, 2018

QA notes: Basically just make sure there are equivalent brave:// pages. I think this broke at some point so if so pls post a new issue and link it here. Don't re-open though as this is estimated work already accounted for and was working at some point.

@btlechowski
Copy link

Deleted QA/Needed as the issue regressed #810 and is still not fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants