Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing brave:// alias doesn't forward to chrome:// #810

Closed
srirambv opened this issue Aug 22, 2018 · 3 comments
Closed

Accessing brave:// alias doesn't forward to chrome:// #810

srirambv opened this issue Aug 22, 2018 · 3 comments

Comments

@srirambv
Copy link
Contributor

Description

Accessing brave:// alias doesn't forward to chrome://

Steps to Reproduce

  1. Build from master (790d5db)
  2. Open a new tab and load brave://version
  3. Does a search for the URL instead of forwarding to chrome://version

Actual result:

Does a search for the URL instead of forwarding to chrome://<URL>

Expected result:

Should forward to chrome://<URL>

Reproduces how often:

100%

Brave version (about:brave info)

Brave 0.55.1 Chromium: 69.0.3497.42 (Official Build) (64-bit)
Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS Windows
JavaScript V8 6.9.427.14
Flash (Disabled)

Reproducible on current release:

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

#213

@bbondy
Copy link
Member

bbondy commented Sep 9, 2018

Moving to 1.x, not the end of the world, it is handled but it's not sorted first for autocomplete yet.

@bbondy bbondy modified the milestones: Releasable builds 0.55.x, 1.x Backlog Sep 9, 2018
bbondy pushed a commit to brave/brave-core that referenced this issue Oct 12, 2018
This only affects the DisplayURL in that, when the url is being edited or copied, the actual chrome://*** url will be present.
This seems acceptable given:
- These urls 99% of the time are for display purposes only, as a result of another UI action, and will not be typed manually
- We intend to support brave://*** actual urls, redirecting to chrome://*** actual URLs automatically, which will get displayed as brave://*** URLs (brave/brave-browser#810)

Fix brave/brave-browser#1458
petemill added a commit to brave/brave-core that referenced this issue Oct 13, 2018
This only affects the DisplayURL in that, when the url is being edited or copied, the actual chrome://*** url will be present.
This seems acceptable given:
- These urls 99% of the time are for display purposes only, as a result of another UI action, and will not be typed manually
- We intend to support brave://*** actual urls, redirecting to chrome://*** actual URLs automatically, which will get displayed as brave://*** URLs (brave/brave-browser#810)

Fix brave/brave-browser#1458
@srirambv
Copy link
Contributor Author

@bbondy @petemill can this be closed now since brave/brave-core#584 is already merged into 0.55.x and correctly shows brave:// and loads correctly?

@bbondy
Copy link
Member

bbondy commented Oct 16, 2018

yep!

@bbondy bbondy closed this as completed Oct 16, 2018
@bbondy bbondy modified the milestones: 1.x Backlog, FROZEN: 0.55.x - Release Oct 16, 2018
@bbondy bbondy added QA/No and removed QA/Yes labels Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants