Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try Brave Search translated text isn't confined within the button in search promo banner message #24005

Closed
GeetaSarvadnya opened this issue Jul 12, 2022 · 3 comments · Fixed by brave/brave-core#14160

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #23914
Try Brave Search translated text isn't confined within the button in the search promo banner message

Steps to Reproduce

  1. Set OS locale to Germany/Kannada/Hindi/France
  2. Launch brave using brave.exe --enable-features=BraveSearchOmniboxBanner
  3. Change the search engine to other apart from brave
  4. Enter any text in the URL bar
  5. Search promo banner message is shown
  6. Try Brave Search translated text isn't confined within the button in search promo banner message

Actual result:

Try Brave Search translated text isn't confined within the button in search promo banner message
image

Expected result:

Try Brave Search translated text should be shown entirely within the button

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.41.96 Chromium: 103.0.5060.114 (Offizieller Build) (64-Bit)
Überarbeitung a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
Betriebssystem Windows 10 Version 21H2 (Build 19044.1806)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? NA

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @mkarolin @rebron @brave/qa-team

@mkarolin
Copy link
Contributor

cc: @simonhong

@kjozwiak
Copy link
Member

The above will require 1.42.67 or higher for 1.42.x verification 👍

@stephendonner
Copy link

Verified PASSED using

Brave 1.42.67 Chromium: 103.0.5060.114 (Official Build) beta (x86_64)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS macOS Version 13.0 (Build 22A5295i)

Steps:

  1. set OS locale to Germany, France (couldn't reproduce the search banner in Hindi and Kannada)
  2. launched Brave using --enable-features=BraveSearchOmniboxBanner
  3. changed the search engine to DuckDuckGo
  4. entered basic attention token in the URL bar
  5. search promo banner message is shown

Confirmed the translated Try Brave Search... text fits the button in the following locales:

German French
Bildschirm­foto 2022-07-15 um 12 39 16 Capture d’écran 2022-07-15 à 12 44 16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment