Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed static size setting to try button in promotion view #14160

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jul 13, 2022

fix brave/brave-browser#24005

Deleted accidently added size setting code.

Resolves

Screen Shot 2022-07-13 at 9 51 16 PM

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the linked issue

@simonhong simonhong requested a review from sangwoo108 July 13, 2022 13:02
@simonhong simonhong self-assigned this Jul 13, 2022
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong simonhong merged commit 33de015 into master Jul 14, 2022
@simonhong simonhong deleted the fix_wrong_try_button_width_in_promotion_view branch July 14, 2022 00:35
@simonhong simonhong added this to the 1.43.x - Nightly milestone Jul 14, 2022
brave-builds pushed a commit that referenced this pull request Jul 14, 2022
@GeetaSarvadnya
Copy link

Verification PASSED on


Brave | 1.43.23 Chromium: 103.0.5060.114 (Official Build) nightly (64-bit)
-- | --
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | Windows 10 Version 21H2 (Build 19044.1826)

Brave Search promo banner type

Germany France Kannada Hindi
image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try Brave Search translated text isn't confined within the button in search promo banner message
3 participants