Enable notifications from Brave to earn modal not appearing if All "Brave Ads" notifications disabled

[kjozwiak]

Description

We should be showing the Enable notifications from Brave to earn Brave Rewards. modal when All "Brave Ads" notifications has been disabled but All Brave notifications is still enabled. With the current implementation, we're just checking All Brave notifications. However, a user could leave all their notifications enabled and just disable All "Brave Ads" notifications and still be able to enable rewards which puts them into the same state we tried to avoid with the Enable notifications from Brave to earn Brave Rewards. modal.

Steps to reproduce

1. download/install 1.47.175 Chromium: 109.0.5414.87
2. run through all the onboarding (can disable Notifications via this step if you're on Android 13
3. go into Settings -> Notification and disable All Brave notifications
4. once disabled, go back into the NTP and tap on the rewards panel
5. select a country via the Country Selection and you'll notice you can't enable rewards due to notifications being disabled
6. on the warning modal re: notifications being disabled, tap on Open Settings
7. enable All Brave notifications but disable All "Brave Ads" notifications
8. go back into the NTP and you'll notice you can now run through/enable rewards with notifications still disabled

Actual result

screen-20230117-012303.mp4

Expected result

Should be showing the following modal if a user has All "Brave Ads" notifications disabled and attempts to enable rewards:

Issue reproduces how often

100% reproducible using the STR/Cases outlined above.

Version/Channel Information:

• Can you reproduce this issue with the current Play Store version? Yes
• Can you reproduce this issue with the current Play Store Beta version? Yes
• Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

• Install type (ARM, x86): ARM
• Device type (Phone, Tablet, Phablet): Pixel 6 (Phone)
• Android version: Android 13

Brave version

Brave | 1.47.175 Chromium: 109.0.5414.87 (Official Build) (32-bit)
--- |  ---
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Android 13; Build/T2B2.221216.006

Website problems only

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Additional information

@deeppandya @timchilds @sujitacharya2005 @Uni-verse

[kjozwiak]

@brave/qa-team more detailed STR/Cases can also be found via brave/brave-core#16740 (comment) 👍

[kjozwiak]

The above requires 1.48.154 or higher for 1.48.x verification 👍

[kjozwiak]

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.48.155 Chromium: 110.0.5481.77 (Official Build) (32-bit)
--- | ---
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Android 13; Build/TQ1A.230105.002

As per @deeppandya, we don't block users from opting into Brave Rewards when they have notifications disabled. We display the warning but a user can dismiss the modal by pressing X and continue with onboarding. So the following verifies that the user received a warning when disabling either All Brave - notifications or All "Brave Ads" notification channels from Notifications settings.

Test Case #1 - not enabling notifications via initial onboarding

• installed 1.48.155 Chromium: 110.0.5481.77
• tap on Continue under the Brave notifications make it easier onboarding
• tap on Dont allow under the All Brave - Nightly to send you notifications? modal
• tap on the rewards panel and select a country via the Select your country panel
• tapping on Continue should display the Enable notifications from Brave to earn Brave Rewards modal
  • ensured that tapping X dismisses the modal and you can still run/setup rewards via the panel
  • ensured that tapping on Open Settings opens Notifications under Settings

screen-20230206-181407.mp4

Test Case #2 - disabling All Brave - notifications via Settings -> Notifications

• installed 1.48.155 Chromium: 110.0.5481.77
• tap on Continue under the Brave notifications make it easier onboarding
• tap on Allow under the All Brave - Nightly to send you notifications? modal
• disable All Brave - notifications via Hamburger Menu -> Settings -> Notifications
• tap on the rewards panel via NTP and select a country via the Select your country panel
• tapping on Continue should display the Enable notifications from Brave to earn Brave Rewards modal
  • ensured that tapping X dismisses the modal and you can still run/setup rewards via the panel
  • ensured that tapping on Open Settings opens Notifications under Settings

screen-20230206-182346.mp4

Test Case #3 - disabling All "Brave Ads" notification via Settings -> Notifications

• installed 1.48.155 Chromium: 110.0.5481.77
• tap on Continue under the Brave notifications make it easier onboarding
• tap on Allow under the All Brave - Nightly to send you notifications? modal
• disable All "Brave Ads" notification via Hamburger Menu -> Settings -> Notifications
• tap on the rewards panel via NTP and select a country via the Select your country panel
• tapping on Continue should display the Enable notifications from Brave to earn Brave Rewards modal
  • ensured that tapping X dismisses the modal and you can still run/setup rewards via the panel
  • ensured that tapping on Open Settings opens Notifications under Settings

screen-20230206-181847.mp4