Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave notification permission issue fix (uplift to 1.48.x) #16782

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Brave notification permission issue fix (uplift to 1.48.x) #16782

merged 1 commit into from
Feb 2, 2023

Conversation

sujitacharya2005
Copy link
Contributor

@sujitacharya2005 sujitacharya2005 commented Jan 21, 2023 •
edited by kjozwiak
Loading

Uplift of #16740
Resolves brave/brave-browser#27851
Resolves brave/brave-browser#27852
Resolves brave/brave-browser#27853

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@sujitacharya2005 sujitacharya2005 added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 21, 2023
@sujitacharya2005 sujitacharya2005 added this to the 1.48.x - Beta milestone Jan 21, 2023
@sujitacharya2005 sujitacharya2005 requested a review from a team as a code owner January 21, 2023 07:19
@sujitacharya2005 sujitacharya2005 self-assigned this Jan 21, 2023
@sujitacharya2005 sujitacharya2005 force-pushed the 16740_27851_27852_27853_brave_notification_fix_1.48.x branch 2 times, most recently from 7caff50 to 90b42d8 Compare February 1, 2023 20:19
@sujitacharya2005 sujitacharya2005 force-pushed the 16740_27851_27852_27853_brave_notification_fix_1.48.x branch from 90b42d8 to 3476a21 Compare February 2, 2023 07:55
kjozwiak
kjozwiak approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.48.x approved 👍 QA has verified the PR on Nightly as per #16740 (comment).

@kjozwiak kjozwiak merged commit ce26a10 into 1.48.x Feb 2, 2023
@kjozwiak kjozwiak deleted the 16740_27851_27852_27853_brave_notification_fix_1.48.x branch February 2, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@sujitacharya2005 sujitacharya2005

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@sujitacharya2005 @kjozwiak