Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave notification permission issue fix (uplift to 1.47.x) #16781

Closed
wants to merge 1 commit into from
Closed

Brave notification permission issue fix (uplift to 1.47.x) #16781

wants to merge 1 commit into from

Conversation

sujitacharya2005
Copy link
Contributor

Uplift of #16740
Resolves
brave/brave-browser#27851
brave/brave-browser#27852
brave/brave-browser#27853

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@sujitacharya2005 sujitacharya2005 added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 21, 2023
@sujitacharya2005 sujitacharya2005 added this to the 1.47.x - Release #4 milestone Jan 21, 2023
@sujitacharya2005 sujitacharya2005 self-assigned this Jan 21, 2023
@sujitacharya2005 sujitacharya2005 requested a review from a team as a code owner January 21, 2023 07:11
@sujitacharya2005 sujitacharya2005 changed the title Brave notification permission issue fix Brave notification permission issue fix (uplift to 1.47.x) Jan 21, 2023
kjozwiak
kjozwiak reviewed Jan 23, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to close this off as we'll get it into 1.48.x via #16782. Found an issue already while quickly running through the above which we'll need to be addressed as well. As discussed before, the above ones aren't blockers and don't need to go into the 1.47.x maintenance release.

@kjozwiak kjozwiak closed this Jan 23, 2023
@kjozwiak kjozwiak deleted the 16740_27851_27852_27853_brave_notification_fix_1.47.x branch January 23, 2023 05:50
@kjozwiak kjozwiak removed CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 23, 2023
@kjozwiak kjozwiak removed this from the 1.47.x - Release #4 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sujitacharya2005 @kjozwiak