Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First paint performance degradation for v1.49.41..v1.49.45 #27997

Closed
atuchin-m opened this issue Jan 24, 2023 · 5 comments · Fixed by brave/brave-core#16868
Closed

First paint performance degradation for v1.49.41..v1.49.45 #27997

atuchin-m opened this issue Jan 24, 2023 · 5 comments · Fixed by brave/brave-core#16868

Comments

@atuchin-m
Copy link
Contributor

Found by brave-perf-dashboard:
https://brave-perf-dashboard.appspot.com/report?sid=81cf487b0d145dbb968f6ba1e9578ad3fb9b61bd94855077f4247ccb27169851
Slack thread: https://bravesoftware.slack.com/archives/C3T9S9WKD/p1674560540571669
image

@atuchin-m
Copy link
Contributor Author

Confirmed: the perf degradation is fixed: brave/brave-core#16900 (comment)

@brave-builds brave-builds modified the milestones: 1.49.x - Nightly, 1.48.x - Beta, 1.47.x - Release #6 Jan 30, 2023
@kjozwiak
Copy link
Member

Confirmed: the perf degradation is fixed: brave/brave-core#16900 (comment)

@atuchin-m I'm not sure if QA can do anything re: the above. Will the performance team run through the same check that was done via brave/brave-core#16900 (comment) on both the 1.48.x and 1.47.x channels? Regarding QA, @srirambv will run through the same cases as before via #27340 (comment).

If we're going to check the performance against both 1.48.x and 1.47.x, we can leave this opened and label it as QA Pass once completed. However, if we're only checking on master, we can label this as QA/No unless @darkdh has anything that he would like QA to run through regarding the above.

@atuchin-m
Copy link
Contributor Author

@kjozwiak I believe checking PR performance on nightly was enough for that issue.
cc @iefremov

@kjozwiak
Copy link
Member

kjozwiak commented Feb 6, 2023

Going to label this one as QA/No as per #27997 (comment). However, QA still run through #27340 similar to what @srirambv did via #27340 (comment).

@kjozwiak kjozwiak added QA/No and removed QA/Yes labels Feb 6, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Feb 6, 2023

Moving this into 1.48.x as we neve received another C109 minor chromium bump that would have triggered another 1.47.x release. We'll leave https://github.com/brave/brave-core/milestone/267 as there's code that landed in 1.47.x but we'll close off the 1.47.x - Release #6 milestone and move all the issues within 1.48.x.

The above can be verified with 1.48.156 for 1.48.x as it's been merged into a 1.48.x a while ago as per brave/brave-core#16900.

@kjozwiak kjozwiak modified the milestones: 1.47.x - Release #6, 1.48.x - Release Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants