Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mitigate perf degradation cause by loading wallet-standard (1.48.x) #16900

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Mitigate perf degradation cause by loading wallet-standard (1.48.x) #16900

merged 1 commit into from
Jan 30, 2023

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Jan 28, 2023 •
edited by kjozwiak
Loading

Uplift of #16868
Resolves brave/brave-browser#27997

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@darkdh
Uplift of #16868 (squashed) to beta
21e9c09 
Mitigate perf degradation cause by loading wallet-standard
@darkdh darkdh requested a review from a team as a code owner January 28, 2023 00:39
@darkdh darkdh self-assigned this Jan 28, 2023
@kjozwiak kjozwiak added this to the 1.48.x - Beta milestone Jan 28, 2023
@atuchin-m
Copy link
Collaborator

Performance verified on nightly v1.49.75, mac:

  1. No unexpected long tasks on the JS perftrace on example.com.
  2. Metrics on the perf dashboard are returned to the expected values.
    image

@atuchin-m atuchin-m mentioned this pull request Jan 30, 2023
Closed
kjozwiak
kjozwiak approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.48.x approved 👍

@kjozwiak kjozwiak merged commit d047ae8 into 1.48.x Jan 30, 2023
@kjozwiak kjozwiak deleted the pr16868_wallet-standard-perf_1.48.x branch January 30, 2023 18:11
@kjozwiak kjozwiak changed the title Uplift of #16868 (squashed) to beta Mitigate perf degradation cause by loading wallet-standard (1.48.x) Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@darkdh darkdh

Labels
None yet
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@darkdh @atuchin-m @kjozwiak