Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide in app purchase details #28910

Closed
deeppandya opened this issue Mar 6, 2023 · 2 comments · Fixed by brave/brave-core#17509
Closed

Hide in app purchase details #28910

deeppandya opened this issue Mar 6, 2023 · 2 comments · Fixed by brave/brave-core#17509
Assignees

Comments

@deeppandya
Copy link

This issue is to hide manage subscription , expires , status if user has an active desktop subscription and only show them if the subscription is through in app purchase.

For more details : https://bravesoftware.slack.com/archives/C021S0FN3V1/p1677776529727149

@kjozwiak
Copy link
Member

The above requires 1.49.124 or higher for 1.49.x verification 👍

@Uni-verse
Copy link
Contributor

Verified on Samsung GS 21 5G using version(s):

Brave	1.49.129 Chromium: 111.0.5563.116 (Official Build) (64-bit) 
Revision	ade86b9472831e26d87fd569e04b404be01e1e2b-refs/branch-heads/5563@{#1209}
OS	Android 13;

Test Plan:

  1. Purchase VPN desktop client using production credentials
  2. Install 1.49.129 on Android device
  3. Redeem VPN from account.brave.com
  4. Enable VPN profile
  5. Open VPN settings
  6. Confirm manage subscription , expires , status fields are hidden
  • Ensured manage subscription, expires and status fields are hidden
  • Ensured user is able to enable VPN profile and it is functional
  • Ensured manage subscription, expires and status fields are shown when purchasing VPN subscription on Android app using IAP.
Example Example Example Example
screenshot-1679530472837 screenshot-1679530498645 screenshot-1679530528529 screenshot-1679530546547

VPN subscription purchased on Android app

Example Example Example
screenshot-1679497508927 screenshot-1679497529048 screenshot-1679500973821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants