Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change subscription details based on platform (uplift to 1.49.x) #17532

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Change subscription details based on platform (uplift to 1.49.x) #17532

merged 1 commit into from
Mar 14, 2023

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Mar 8, 2023 •
edited by kjozwiak
Loading

Uplift of #17509
Resolves brave/brave-browser#28910

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner March 8, 2023 16:51
@brave-builds brave-builds self-assigned this Mar 8, 2023
@brave-builds brave-builds added this to the 1.49.x - Release milestone Mar 8, 2023
@deeppandya
Copy link
Contributor

@kjozwiak this uplift is for 1.49.x maintenance release. Not for the main release

@kjozwiak
Copy link
Member

kjozwiak commented Mar 8, 2023

@kjozwiak this uplift is for 1.49.x maintenance release. Not for the main release

Added the PR/Blocked for now until we get 1.49.x out on March 9th. Once the initial 1.49.x gets released, we can get this merged into the 1.49.x branch for the maintenance release scheduled for March 22, 2023.

kjozwiak
kjozwiak approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.49.x approved 👍 QA has verified the PR on Nightly as per #17509 (comment).

@kjozwiak kjozwiak merged commit 27caf42 into 1.49.x Mar 14, 2023
@kjozwiak kjozwiak deleted the pr17509_change_subscription_detail_behaviour_1.49.x branch March 14, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
Uplift/Blocked
Projects
None yet
Milestone
1.49.x - Release #3
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @deeppandya @kjozwiak