Big Regression: Latest version broke keyboard commands for copying text and pasting it

[AustinGitHub]

Edit: Next version will have fix see comment below #29074 (comment)
Leaving open until release is public to confirm again the issue is fixed.

https://community.brave.com/t/latest-update-broke-copy-to-clipboard-with-keyboard-shortcuts/476641
https://community.brave.com/t/copy-keyboard-shortcut-c-sometimes-copies-location-instead-of-highlighted-text/476830
https://community.brave.com/t/in-some-tabs-c-is-copying-a-clean-link-of-the-page-not-copying-selected-text/476706/3

Video

Screen.Recording.2023-03-14.at.7.12.32.PM.mov

Work-around

Update to latest version of Brave, then open brave://flags/#brave-copy-clean-link-by-default and set this flag to Disabled:

[AustinGitHub]

Why is copy clean link the default for copying text? Who made this change? This is such a major change that I am confused on why this key shortcut was automatically changed and forced onto users

[AustinGitHub]

pinged few PRs that might be related to this issue. I'm trying to understand why this was a forced global change and not change the user can set themselves. This type of change should never be forced on users as it is standard that command+c is to copy text, not clean link. This is industry standard keyboard shortcut, to change this to a different command is one way to get people to switch browsers (I've been considering it if this isn't fixed, I'm not going to lie)

[spylogsster]

Hi @AustinGitHub, thanks for reporting, this should be fixed in Nightly already, can you try pls?
cc @fmarier

[AustinGitHub]

my browser didn't get the update yet but I'll keep an eye on it

[AustinGitHub]

I am on this build

[spylogsster]

@AustinGitHub Nigthly is a separate channel (and installed independelty to computer), it can be downloaded here https://brave.com/download-nightly/, stable builds will be updated with this fix a bit later

[AustinGitHub]

ok I will try it out in the morning and see, thanks!

[AustinGitHub]

I checked and this is fixed in nightly, when can it be expected for the actual brave browser? Thanks!

[fmarier]

@AustinGitHub Thanks for the confirmation.

We are preparing to uplift the fixes to the release channel and will QA them.

[AustinGitHub]

Thanks! If it's ok, I'd like to leave the issue open until release so people know about it and that when release I can double confirm it and close this out. Thanks!

[crypto-machia]

Thank you for opening this issue @AustinGitHub! The issue has pretty much made Brave unusable for me the last few days and was also considering switching default to Chrome. Hope this new release comes quickly.

[crypto-machia]

@AustinGitHub Do you know where I can change default from copy clean link back to copy text? I don't see that anywhere in preferences.

[AustinGitHub]

@AustinGitHub Do you know where I can change default from copy clean link back to copy text? I don't see that anywhere in preferences.

They said it's in their other nightly browser version, though this version may contain other bugs so be wary #29074 (comment) I plan to just wait personally for the full release for the fix, hoping it's soon though. Thanks!

[fmarier]

Thanks! If it's ok, I'd like to leave the issue open until release so people know about it and that when release I can double confirm it and close this out. Thanks!

Yes, that's a good idea. That way other affected users can more easily find it.

I'll assign @spylogsster since he has fixed the bugs in Nightly and prepared the uplift.

[spylogsster]

PRs to track it easier:

Beta:

• Do not show copy clean link for plain text (uplift #17541) brave-core#17608
• Check focus for location bar view (uplift to 1.50.x) brave-core#17606
• Copy keyboard shortcut is not assigned to 'copy clean link' in contex… (uplift to 1.50.x) brave-core#17607

Stable:

• Copy keyboard shortcut is not assigned to 'copy clean link' in contex…(uplift #17487) brave-core#17610
• Check focus for location bar view (uplift of #17573) brave-core#17611
• Do not show copy clean link for plain text (uplift #17541) brave-core#17609

[rrajkowski]

Has this fix been released yet (not Nightly)? I'm on latest +Mac OS 12.4 and still experiencing this issue.

Brave is up to date
[Version 1.49.120 Chromium: 111.0.5563.64 (Official Build) (x86_64)](https://brave.com/latest/)

[spylogsster]

Has this fix been released yet (not Nightly)? I'm on latest +Mac OS 12.4 and still experiencing this issue.

Brave is up to date
[Version 1.49.120 Chromium: 111.0.5563.64 (Official Build) (x86_64)](https://brave.com/latest/)

Not yet, wait until that PRs merged #29074 (comment)

[TokuTrex]

Also having the same issue. It's driving me crazy, I have a lot of text I copy for work, please fix this soon. Thanks

[fmarier]

Thanks for all of the feedback and testing. Our fixes for macOS look like they did not address all of the corner cases that people are running into. We will be flipping the flag to off-by-default on Monday. A PR and hotfix are also coming: brave/brave-core#17752

[AustinGitHub]

Just got the update, I turned flag off to disabled for this, I'll update sunday night how well this worked for me over weekend. Thanks!

[rodrigoamds]

I am currently using version 1.49.128 and I have noticed that some pages, like TikTok, still do not have their 'copy' functionality working properly. Thank you for your attention.

[tripleee]

As a tedious, and ultimately untenable workaround you can control-click on the selected text and get a dropdown menu whose Copy command works.

[AustinGitHub]

Just got the update, I turned flag off to disabled for this, I'll update sunday night how well this worked for me over weekend. Thanks!

updating, this worked for me, thanks!

[Taifun07]

Hi, this issue started again!
All of a sudden cmd+C in Google sheets copies the link.
How to fix this awful mistake of a "feature"?

[spylogsster]

@Taifun07 on brave://flags page you can disable Override default copy hotkey with copy clean link:

[fmarier]

@Taifun07 What version of the browser are you using? 1.49.132 is the one that has cmd+C mapped to regular copy.

[simon-contreras-deel]

OMG, it is happening again!!! Version v1.49.132 in mac

The flag to disable it is working fine (but I needed to restart the browser)

[FelikZ]

Having flag disabled - fixed issue for me. Should be default.

[Taifun07]

@Taifun07 What version of the browser are you using? 1.49.132 is the one that has cmd+C mapped to regular copy.

Right now I have 1.49.132. version
Since I disabled this feature it is fixed now.
The interesting part is, that it was turning on auto when a tab with any Google product is open.

[spylogsster]

Hi everyone, Im still trying to reproduce the issue on macos with enabled feature on google sheets and looks like it depends on some focus traveling between windows/elements to reproduce. It would be great if someone can help and post videos from the browser launch to the problem with visible focus switches. Many thanks.

[nielsmadan]

Good lord. How did this ever make it into a production build? Time for some root cause analysis and improvements to your QA process, yes?

[AustinGitHub]

I think we can close this right? @spylogsster Thanks!

[MiriamWeyden]

The problem is not fixed yet, did I miss an update?

[AustinGitHub]

It should be, go to brave://flags/ and then disable override hotkey of copy clean link and it should be fine

[MiriamWeyden]

Unfortunately, no results for this with me.

[AustinGitHub]

what version of brave are you on?
I am using
[Version 1.50.121 Chromium: 112.0.5615.138 (Official Build) (64-bit)](https://brave.com/latest/) check if there is a new version

[AustinGitHub]

oh I see you're on 111.1.49.120
update your browser

[MiriamWeyden]

Thank you so much, didn't see the last update. Now I was able to set it!