Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#17254 Cannot copy autocompleted url on macos uplift to 1.49.x #17435

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

spylogsster
Copy link
Contributor

Uplift of #17254
Resolves brave/brave-browser#28542

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@spylogsster spylogsster requested a review from a team as a code owner March 1, 2023 20:20
@spylogsster spylogsster self-assigned this Mar 1, 2023
@spylogsster spylogsster changed the title #17254 uplift to 1.49.x #17254 Cannot copy autocompleted url on macos uplift to 1.49.x Mar 1, 2023
@kjozwiak kjozwiak added this to the 1.49.x - Release milestone Mar 2, 2023
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.49.x approved 👍 QA has verified the PR on Nightly as per #17254 (comment).

@kjozwiak kjozwiak merged commit 431d506 into 1.49.x Mar 2, 2023
@kjozwiak kjozwiak deleted the 17254_uplift_to_1.49.x branch March 2, 2023 20:17
@AustinGitHub
Copy link

I think this is the PR that caused a regression brave/brave-browser#29074 I am trying to find the source for why it was decided to change the keyboard shortcut to "copy clean link" automatically for users, this is a major regression as it disturbs the actual functionality of using copy/paste, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants