Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy url from omnibox instead of webcontent #17254

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Copy url from omnibox instead of webcontent #17254

merged 1 commit into from
Feb 17, 2023

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 16, 2023

Resolves brave/brave-browser#28542

Mac sometimes sends command via app controlller and there is an intersection with app menu overriding feature. Fixed it by copying url from omnibox instead of webcontent in this case.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • steps from issue

Comment on lines +292 to +295
auto* brave_browser_window = BraveBrowserWindow::From(browser->window());
if (brave_browser_window) {
brave_browser_window->CleanAndCopySelectedURL();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious this could be for IDC_COPY_CLEAN_LINK in BraveBrowserCommandController::ExecuteBraveCommandWithDisposition?
Honestly confusing when we can use chrome::ExecuteCommand(browser, IDC_COPY_CLEAN_LINK); or not.

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@spylogsster spylogsster merged commit d7e38a1 into master Feb 17, 2023
@spylogsster spylogsster deleted the brave-28542 branch February 17, 2023 05:44
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 17, 2023
@spylogsster spylogsster restored the brave-28542 branch March 1, 2023 20:14
@kjozwiak
Copy link
Member

kjozwiak commented Mar 2, 2023

Verification PASSED on macOS 13.2.1 x64 using the following build(s):

Brave | 1.51.2 Chromium: 111.0.5563.50 (Official Build) nightly (x86_64)
--- | ---
Revision | 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS | macOS Version 13.2.1 (Build 22D68)

Using the STR/Cases outlined via brave/brave-browser#28542 (comment), reproduced hte original issue using 1.50.43 Chromium: 110.0.5481.100. Verified that copying autocomplete URLs from the omnibox works as expected. In my case, I typed in khan and copied https://khanacademy.org and ensured that pasting worked as expected and chrome://newtab wasn't being copied.

@kjozwiak kjozwiak deleted the brave-28542 branch March 2, 2023 20:11
kjozwiak pushed a commit that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot copy autocompleted url on macos
3 participants