-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy url from omnibox instead of webcontent #17254
Conversation
auto* brave_browser_window = BraveBrowserWindow::From(browser->window()); | ||
if (brave_browser_window) { | ||
brave_browser_window->CleanAndCopySelectedURL(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious this could be for IDC_COPY_CLEAN_LINK
in BraveBrowserCommandController::ExecuteBraveCommandWithDisposition
?
Honestly confusing when we can use chrome::ExecuteCommand(browser, IDC_COPY_CLEAN_LINK);
or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Verification PASSED on
Using the STR/Cases outlined via brave/brave-browser#28542 (comment), reproduced hte original issue using |
Resolves brave/brave-browser#28542
Mac sometimes sends command via app controlller and there is an intersection with app menu overriding feature. Fixed it by copying url from omnibox instead of webcontent in this case.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: