Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update download button progress color in dark theme #29434

Closed
simonhong opened this issue Mar 31, 2023 · 1 comment · Fixed by brave/brave-core#17845
Closed

Update download button progress color in dark theme #29434

simonhong opened this issue Mar 31, 2023 · 1 comment · Fixed by brave/brave-core#17845
Assignees
@simonhong
Labels
feature/user-interface All UI related OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.52.x - Release

Comments

@simonhong
Copy link
Member

F/U for #29324 (comment)

  1. Set dark mode
  2. Start downloading any file and check progress ring color is easily visible
@simonhong simonhong self-assigned this Mar 31, 2023
simonhong added a commit to brave/brave-core that referenced this issue Mar 31, 2023
@simonhong
Updated download button progress color in dark theme
2fb8473 
fix brave/brave-browser#29434
@simonhong simonhong mentioned this issue Mar 31, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Mar 31, 2023
@stephendonner
Copy link

stephendonner commented May 3, 2023 •
edited
Loading

Verified PASSED using

Brave 1.52.84 Chromium: 113.0.5672.63 (Official Build) beta (x86_64)
Revision 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS macOS Version 11.7.6 (Build 20G1231)

Used the testplan from brave/brave-core#17845 (comment)

Steps:

  1. installed 1.52.84
  2. launched Brave
  3. set Brave colors via brave://settings/appearance to Dark
  4. loaded https://www.leaseweb.com/platform/network
  5. clicked on a large-sized file, and downloaded it
  6. checked the download button's progress color

Confirmed the color/hue matches that in the test plan

Dark Light
Screen Shot 2023-05-03 at 2 53 19 PM Screen Shot 2023-05-03 at 2 52 53 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/user-interface All UI related OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

Updated download button progress color in dark theme brave/brave-core
3 participants
@stephendonner @simonhong @brave-builds