-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update toolbar's download button style #29324
Comments
The above requires |
@rebron maybe we should look into using another colour for the progress indication in dark mode? It's pretty hard to see as we're using a dark blue against black. It's not the easiest to see. Example via brave/brave-core#17769 (comment). |
@aguscruiz We probably want to go lighter color for contrast for dark mode. Really subtle with the progress bar. |
Verified with
Verification PASSED on
|
Verification
|
In progress (captured from figma)
![Screenshot 2023-03-27 at 3 37 40 PM](https://user-images.githubusercontent.com/6786187/227860636-004ba0a8-2174-44fb-a7bd-317f773b26a8.png)
![Screenshot 2023-03-27 at 3 43 49 PM](https://user-images.githubusercontent.com/6786187/227861256-8553feb8-6c32-47c6-927e-faf093a546d8.png)
Completed
![Screenshot 2023-03-27 at 3 37 53 PM](https://user-images.githubusercontent.com/6786187/227860642-5dee852f-3fde-4a10-9b33-2e481c1aba2a.png)
![Screenshot 2023-03-27 at 3 43 58 PM](https://user-images.githubusercontent.com/6786187/227861289-5a568f49-eb26-447f-af84-690c94fb0bed.png)
The text was updated successfully, but these errors were encountered: