Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toolbar's download button style #29324

Closed
simonhong opened this issue Mar 27, 2023 · 5 comments · Fixed by brave/brave-core#17769
Closed

Update toolbar's download button style #29324

simonhong opened this issue Mar 27, 2023 · 5 comments · Fixed by brave/brave-core#17769

Comments

@simonhong
Copy link
Member

simonhong commented Mar 27, 2023

In progress (captured from figma)
Screenshot 2023-03-27 at 3 37 40 PM
Screenshot 2023-03-27 at 3 43 49 PM

Completed
Screenshot 2023-03-27 at 3 37 53 PM
Screenshot 2023-03-27 at 3 43 58 PM

@kjozwiak
Copy link
Member

The above requires 1.50.110 or higher for 1.50.x verification 👍

@kjozwiak
Copy link
Member

@rebron maybe we should look into using another colour for the progress indication in dark mode? It's pretty hard to see as we're using a dark blue against black. It's not the easiest to see. Example via brave/brave-core#17769 (comment).

@kjozwiak kjozwiak added the feature/user-interface All UI related label Mar 29, 2023
@rebron
Copy link
Collaborator

rebron commented Mar 29, 2023

@aguscruiz We probably want to go lighter color for contrast for dark mode. Really subtle with the progress bar.

@LaurenWags
Copy link
Member

LaurenWags commented Mar 31, 2023

Verified with

Brave | 1.50.110 Chromium: 112.0.5615.49 (Official Build) (x86_64)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | macOS Version 12.6.4 (Build 21G526)
Normal Window - PASSED
Light theme Dark theme
Lt in progress Dk in progress
Lt done Dk done
Tor Window - PASSED
Example Example
Tor in progress Tor done
Private Window - PASSED
Example Example
Private in progress Private done
Guest Window - PASSED
Example Example
Guest 1 Guest 2

Verification PASSED on

Brave	1.50.108 Chromium: 112.0.5615.39 (Official Build) (64-bit) 
Revision	a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS	Linux
Normal Window - PASSED
Light theme Dark theme
image image
Light theme Dark theme
image image
Tor Window - PASSED
Example Example
image image
Private Window - PASSED
Example Example
image image
Guest Window - PASSED
Example Example
image image

@MadhaviSeelam
Copy link

Verification PASSED

Brave | 1.50.110 Chromium: 112.0.5615.49 (Official Build) (64-bit)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Windows 11 Version 22H2 (Build 22621.1413)
Normal Window - PASSED
Light theme Dark theme
image image
image image
Tor Window - PASSED
download in-progress download complete
image image
Private Window - PASSED
download in-progress download complete
image image
Guest Window - PASSED
download in-progress download complete
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants