Updated toolbar download button style

fix brave/brave-browser#29324
brave · Mar 28, 2023 · 02f38f7 · 02f38f7
1 parent 3133be3
commit 02f38f7
Show file tree

Hide file tree

Showing 7 changed files with 171 additions and 1 deletion.
diff --git a/browser/ui/color/brave_color_id.h b/browser/ui/color/brave_color_id.h
@@ -24,7 +24,8 @@
     E_CPONLY(kColorWebDiscoveryInfoBarMessage)      \
     E_CPONLY(kColorWebDiscoveryInfoBarLink)         \
     E_CPONLY(kColorWebDiscoveryInfoBarNoThanks)     \
-    E_CPONLY(kColorWebDiscoveryInfoBarClose)
+    E_CPONLY(kColorWebDiscoveryInfoBarClose)        \
+    E_CPONLY(kColorBraveDownloadToolbarButtonActive)
 
 #define BRAVE_SEARCH_CONVERSION_COLOR_IDS                             \
     E_CPONLY(kColorSearchConversionBannerTypeBackgroundBorder)        \

diff --git a/browser/ui/color/brave_color_mixer.cc b/browser/ui/color/brave_color_mixer.cc
@@ -91,6 +91,11 @@ void AddChromeLightThemeColorMixer(ui::ColorProvider* provider,
   mixer[ui::kColorToggleButtonThumbOn] = {SkColorSetRGB(0x4C, 0x54, 0xD2)};
   mixer[ui::kColorToggleButtonTrackOff] = {SkColorSetRGB(0xDA, 0xDC, 0xE8)};
   mixer[ui::kColorToggleButtonTrackOn] = {SkColorSetRGB(0xE1, 0xE2, 0xF6)};
+
+  // Used for download button progress ring color.
+  mixer[kColorDownloadToolbarButtonActive] = {SkColorSetRGB(0x42, 0x3E, 0xEE)};
+  mixer[kColorDownloadToolbarButtonRingBackground] = {
+      SkColorSetARGB(0x0F, 0x1D, 0x1F, 0x25)};
 }
 
 void AddChromeDarkThemeColorMixer(ui::ColorProvider* provider,
@@ -128,6 +133,9 @@ void AddChromeDarkThemeColorMixer(ui::ColorProvider* provider,
   mixer[ui::kColorToggleButtonThumbOn] = {SkColorSetRGB(0x44, 0x36, 0xE1)};
   mixer[ui::kColorToggleButtonTrackOff] = {SkColorSetRGB(0x5E, 0x61, 0x75)};
   mixer[ui::kColorToggleButtonTrackOn] = {SkColorSetRGB(0x76, 0x79, 0xB1)};
+  mixer[kColorDownloadToolbarButtonActive] = {SkColorSetRGB(0x42, 0x3E, 0xEE)};
+  mixer[kColorDownloadToolbarButtonRingBackground] = {
+      SkColorSetARGB(0x33, 0x00, 0x00, 0x00)};
 }
 
 }  // namespace
@@ -274,6 +282,11 @@ void AddBraveLightThemeColorMixer(ui::ColorProvider* provider,
   mixer[kColorWebDiscoveryInfoBarNoThanks] = {SkColorSetRGB(0x6B, 0x70, 0x84)};
   mixer[kColorWebDiscoveryInfoBarClose] = {SkColorSetRGB(0x6B, 0x70, 0x84)};
 
+  // Color for download button when all completed and button needs user
+  // interaction.
+  mixer[kColorBraveDownloadToolbarButtonActive] = {
+      SkColorSetRGB(0x5F, 0x5C, 0xF1)};
+
   // Colors for HelpBubble. IDs are defined in
   // chrome/browser/ui/color/chrome_color_id.h
   mixer[kColorFeaturePromoBubbleBackground] = {SK_ColorWHITE};
@@ -370,6 +383,9 @@ void AddBraveDarkThemeColorMixer(ui::ColorProvider* provider,
   mixer[kColorWebDiscoveryInfoBarClose] = {
       SkColorSetARGB(0xBF, 0x8C, 0x90, 0xA1)};
 
+  mixer[kColorBraveDownloadToolbarButtonActive] = {
+      SkColorSetRGB(0x87, 0x84, 0xF4)};
+
   // Colors for HelpBubble. IDs are defined in
   // chrome/browser/ui/color/chrome_color_id.h
   mixer[kColorFeaturePromoBubbleBackground] = {SkColorSetRGB(0x12, 0x13, 0x16)};

diff --git a/chromium_src/chrome/browser/ui/views/download/bubble/download_toolbar_button_view.cc b/chromium_src/chrome/browser/ui/views/download/bubble/download_toolbar_button_view.cc
@@ -0,0 +1,28 @@
+/* Copyright (c) 2023 The Brave Authors. All rights reserved.
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at https://mozilla.org/MPL/2.0/. */
+
+#include "brave/browser/ui/color/brave_color_id.h"
+
+#include "chrome/browser/ui/views/download/bubble/download_toolbar_button_view.h"
+
+#define DownloadToolbarButtonView DownloadToolbarButtonViewChromium
+
+#include "src/chrome/browser/ui/views/download/bubble/download_toolbar_button_view.cc"
+
+#undef DownloadToolbarButtonView
+
+SkColor DownloadToolbarButtonView::GetIconColor() const {
+  const DownloadDisplayController::IconInfo icon_info = GetIconInfo();
+
+  // Apply active color only when download is completed and user doesn't
+  // interact with this button.
+  if (icon_info.icon_state == download::DownloadIconState::kComplete &&
+      icon_info.is_active) {
+    return GetColorProvider()->GetColor(kColorBraveDownloadToolbarButtonActive);
+  }
+
+  // Otherwise, always use inactive color.
+  return GetColorProvider()->GetColor(kColorDownloadToolbarButtonInactive);
+}
diff --git a/chromium_src/chrome/browser/ui/views/download/bubble/download_toolbar_button_view.h b/chromium_src/chrome/browser/ui/views/download/bubble/download_toolbar_button_view.h
@@ -0,0 +1,38 @@
+/* Copyright (c) 2023 The Brave Authors. All rights reserved.
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at https://mozilla.org/MPL/2.0/. */
+
+#ifndef BRAVE_CHROMIUM_SRC_CHROME_BROWSER_UI_VIEWS_DOWNLOAD_BUBBLE_DOWNLOAD_TOOLBAR_BUTTON_VIEW_H_
+#define BRAVE_CHROMIUM_SRC_CHROME_BROWSER_UI_VIEWS_DOWNLOAD_BUBBLE_DOWNLOAD_TOOLBAR_BUTTON_VIEW_H_
+
+#include "chrome/browser/download/bubble/download_display_controller.h"
+
+#define DownloadToolbarButtonView DownloadToolbarButtonViewChromium
+#define GetIconColor                                        \
+  UnUsed() {                                                \
+    return SK_ColorTRANSPARENT;                             \
+  }                                                         \
+                                                            \
+ protected:                                                 \
+  DownloadDisplayController::IconInfo GetIconInfo() const { \
+    return controller_->GetIconInfo();                      \
+  }                                                         \
+                                                            \
+ public:                                                    \
+  virtual SkColor GetIconColor
+
+#include "src/chrome/browser/ui/views/download/bubble/download_toolbar_button_view.h"  // IWYU pragma: export
+
+#undef GetIconColor
+#undef DownloadToolbarButtonView
+
+class DownloadToolbarButtonView : public DownloadToolbarButtonViewChromium {
+ public:
+  using DownloadToolbarButtonViewChromium::DownloadToolbarButtonViewChromium;
+
+  // DownloadToolbarButtonViewChromium overrides:
+  SkColor GetIconColor() const override;
+};
+
+#endif  // BRAVE_CHROMIUM_SRC_CHROME_BROWSER_UI_VIEWS_DOWNLOAD_BUBBLE_DOWNLOAD_TOOLBAR_BUTTON_VIEW_H_
diff --git a/patches/chrome-browser-ui-views-download-bubble-download_toolbar_button_view.cc.patch b/patches/chrome-browser-ui-views-download-bubble-download_toolbar_button_view.cc.patch
@@ -0,0 +1,13 @@
+diff --git a/chrome/browser/ui/views/download/bubble/download_toolbar_button_view.cc b/chrome/browser/ui/views/download/bubble/download_toolbar_button_view.cc
+index 7d3b2a36ed999db404460e315201f2ef37443f91..1976fe65c7b46e16d1244805c52f82e1a05d188d 100644
+--- a/chrome/browser/ui/views/download/bubble/download_toolbar_button_view.cc
++++ b/chrome/browser/ui/views/download/bubble/download_toolbar_button_view.cc
+@@ -59,7 +59,7 @@
+
+ namespace {
+
+-constexpr int kProgressRingRadius = 9;
++constexpr int kProgressRingRadius = 12;
+ constexpr int kProgressRingRadiusTouchMode = 12;
+ constexpr float kProgressRingStrokeWidth = 1.7f;
+ // 7.5 rows * 60 px per row = 450;
diff --git a/vector_icons/chrome/app/vector_icons/download_in_progress.icon b/vector_icons/chrome/app/vector_icons/download_in_progress.icon
@@ -0,0 +1,37 @@
+// Copyright (c) 2023 The Brave Authors. All rights reserved.
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this file,
+// You can obtain one at https://mozilla.org/MPL/2.0/.
+
+CANVAS_DIMENSIONS, 16,
+MOVE_TO, 8, 0.76f,
+R_CUBIC_TO, 0.32f, 0, 0.59f, 0.27f, 0.59f, 0.59f,
+R_V_LINE_TO, 8.55f,
+R_LINE_TO, 2.32f, -2.32f,
+R_ARC_TO, 0.59f, 0.59f, 0, 0, 1, 0.84f, 0.84f,
+R_LINE_TO, -3.32f, 3.32f,
+R_ARC_TO, 0.59f, 0.59f, 0, 0, 1, -0.84f, 0,
+LINE_TO, 4.26f, 8.42f,
+R_ARC_TO, 0.59f, 0.59f, 0, 0, 1, 0.84f, -0.84f,
+LINE_TO, 7.41f, 9.9f,
+V_LINE_TO, 1.35f,
+ARC_TO, 0.59f, 0.59f, 0, 0, 1, 8, 0.76f,
+CLOSE,
+R_MOVE_TO, -6.65f, 9.97f,
+R_ARC_TO, 0.59f, 0.59f, 0, 0, 1, 0.59f, 0.59f,
+R_V_LINE_TO, 1.66f,
+R_CUBIC_TO, 0, 0.59f, 0.48f, 1.07f, 1.07f, 1.07f,
+R_H_LINE_TO, 9.97f,
+R_CUBIC_TO, 0.59f, 0, 1.07f, -0.48f, 1.07f, -1.07f,
+R_V_LINE_TO, -1.66f,
+R_ARC_TO, 0.59f, 0.59f, 0, 0, 1, 0.59f, -0.59f,
+R_ARC_TO, 0.59f, 0.59f, 0, 0, 1, 0.59f, 0.59f,
+R_V_LINE_TO, 1.66f,
+R_ARC_TO, 2.25f, 2.25f, 0, 0, 1, -2.25f, 2.25f,
+H_LINE_TO, 3.02f,
+R_ARC_TO, 2.25f, 2.25f, 0, 0, 1, -2.25f, -2.25f,
+R_V_LINE_TO, -1.66f,
+R_ARC_TO, 0.59f, 0.59f, 0, 0, 1, 0.59f, -0.59f,
+CLOSE,
+R_MOVE_TO, 0, 0,
+CLOSE
diff --git a/vector_icons/chrome/app/vector_icons/download_toolbar_button.icon b/vector_icons/chrome/app/vector_icons/download_toolbar_button.icon
@@ -0,0 +1,37 @@
+// Copyright (c) 2023 The Brave Authors. All rights reserved.
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this file,
+// You can obtain one at https://mozilla.org/MPL/2.0/.
+
+CANVAS_DIMENSIONS, 16,
+MOVE_TO, 8, 0.76f,
+R_CUBIC_TO, 0.32f, 0, 0.59f, 0.27f, 0.59f, 0.59f,
+R_V_LINE_TO, 8.55f,
+R_LINE_TO, 2.32f, -2.32f,
+R_ARC_TO, 0.59f, 0.59f, 0, 0, 1, 0.84f, 0.84f,
+R_LINE_TO, -3.32f, 3.32f,
+R_ARC_TO, 0.59f, 0.59f, 0, 0, 1, -0.84f, 0,
+LINE_TO, 4.26f, 8.42f,
+R_ARC_TO, 0.59f, 0.59f, 0, 0, 1, 0.84f, -0.84f,
+LINE_TO, 7.41f, 9.9f,
+V_LINE_TO, 1.35f,
+ARC_TO, 0.59f, 0.59f, 0, 0, 1, 8, 0.76f,
+CLOSE,
+R_MOVE_TO, -6.65f, 9.97f,
+R_ARC_TO, 0.59f, 0.59f, 0, 0, 1, 0.59f, 0.59f,
+R_V_LINE_TO, 1.66f,
+R_CUBIC_TO, 0, 0.59f, 0.48f, 1.07f, 1.07f, 1.07f,
+R_H_LINE_TO, 9.97f,
+R_CUBIC_TO, 0.59f, 0, 1.07f, -0.48f, 1.07f, -1.07f,
+R_V_LINE_TO, -1.66f,
+R_ARC_TO, 0.59f, 0.59f, 0, 0, 1, 0.59f, -0.59f,
+R_ARC_TO, 0.59f, 0.59f, 0, 0, 1, 0.59f, 0.59f,
+R_V_LINE_TO, 1.66f,
+R_ARC_TO, 2.25f, 2.25f, 0, 0, 1, -2.25f, 2.25f,
+H_LINE_TO, 3.02f,
+R_ARC_TO, 2.25f, 2.25f, 0, 0, 1, -2.25f, -2.25f,
+R_V_LINE_TO, -1.66f,
+R_ARC_TO, 0.59f, 0.59f, 0, 0, 1, 0.59f, -0.59f,
+CLOSE,
+R_MOVE_TO, 0, 0,
+CLOSE