Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First background image is skipped when branded image is shown after startup #32577

Closed
simonhong opened this issue Aug 29, 2023 · 1 comment · Fixed by brave/brave-core#19915
Closed

Comments

@simonhong
Copy link
Member

Description

When first NTP loading is branded image,
background image(Sean O' Riordan's image) index is also increased at the same time.
So, next NTP loading shows seconds background image.
First background image should not be skipped.

Steps to Reproduce

  1. Change to region that has SI campaign
  2. Launch browser and open NTP and loading multiple times to set next loading will be NTP SI
  3. Shutdown and relaunch
  4. Check NTP shows NTP SI
  5. Reloading

Actual result:

Show second background image

Expected result:

Show first background image

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@simonhong simonhong self-assigned this Aug 29, 2023
simonhong added a commit to brave/brave-core that referenced this issue Aug 29, 2023
fix brave/brave-browser#32577

When NTP is shown after launch and it shows branded image,
next loading should show first background image.
So far background image index is also increased when NTP loads
branded image. It should not be updated to show proper background
for next NTP loading/opening.
@brave-builds brave-builds added this to the 1.59.x - Nightly milestone Aug 31, 2023
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 28, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Sep 28, 2023

Verified with

Brave | 1.59.102 Chromium: 117.0.5938.140 (Official Build) beta (arm64)
-- | --
Revision | 11284b6d5d51252fe1a6fb6b5cba35ef98982357
OS | macOS Version 14.0 (Build 23A344)

Reproduced the issue using STR and 1.58.135 Chromium: 117.0.5938.140, the NTP image after NTP SI in case described was not Sean O' Riordan's.

Verified STR with 1.59.102 Chromium: 117.0.5938.140.
Confirmed the NTP image after NTP SI in case described was Sean O' Riordan's as expected.

1.58.135 1.59.102
1 58 1 59

@LaurenWags LaurenWags added QA Pass-macOS-arm64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment