Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed first background image skipped after launch #19915

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Aug 29, 2023

fix brave/brave-browser#32577

When NTP is shown after launch and it shows branded image,
next loading should show first background image.
So far background image index is also increased when NTP loads branded image.
It should not be updated to show proper background for next NTP loading/opening.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

ViewCounterModelTest.NTPBackgroundImagesTest

See the linkded issue for manual test

fix brave/brave-browser#32577

When NTP is shown after launch and it shows branded image,
next loading should show first background image.
So far background image index is also increased when NTP loads
branded image. It should not be updated to show proper background
for next NTP loading/opening.
@simonhong
Copy link
Member Author

Kindly ping :)

Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simonhong simonhong merged commit e441fe5 into master Aug 31, 2023
15 checks passed
@simonhong simonhong deleted the ntp_background_image branch August 31, 2023 03:35
@github-actions github-actions bot added this to the 1.59.x - Nightly milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First background image is skipped when branded image is shown after startup
2 participants