Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPN toolbar button should have disconnected state when changed to not-purchased state during the runtime #33023

Closed
simonhong opened this issue Sep 15, 2023 · 8 comments · Fixed by brave/brave-core#20533
Closed

VPN toolbar button should have disconnected state when changed to not-purchased state during the runtime #33023

simonhong opened this issue Sep 15, 2023 · 8 comments · Fixed by brave/brave-core#20533
Assignees
@simonhong
Labels
feature/vpn OS/Desktop OS/macOS OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.60.x - Release #5

Comments

@simonhong
Copy link
Member

For now vpn toolbar button can have green state
when purchased state is entered into non-purchased(ex, not purchased or session expired) during the runtime.
It should be gray state in this situation.

STR

  1. Set purchased state and connect to vpn
  2. Check vpn button is green
  3. Reset skus state from brave://skus-internals
  4. Check vpn button is gray
@simonhong simonhong self-assigned this Sep 15, 2023
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Sep 15, 2023
@simonhong simonhong mentioned this issue Oct 16, 2023
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Oct 16, 2023
@simonhong
Fixed vpn button still has connected state for not purchased user
8bdee24 
fix brave/brave-browser#33023

When purchased state is changed to *not* purchased during the runtime,
button should not show as connected.
@brave-builds brave-builds added this to the 1.61.x - Nightly milestone Oct 16, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Nov 1, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.61.60 Chromium: 119.0.6045.105 (Official Build) beta (64-bit)
-- | --
Revision | 1ecda441378e2e473fd84b38456413224121751c
OS | Windows 11 Version 22H2 (Build 22621.2428)
  1. installed 1.61.60
  2. launched Brave
  3. purchase and configured VPN using account.bravesoftware.com
  4. connected to VPN
  5. confirmed VPN toolbar button show green
  6. opened brave://skus-internals
  7. clicked Reset SKUs state button
  8. clicked Ok

Confirmed VPN toolbar button show gray, disconnected state

Confirmed when clicked VPN button, not-purchased state modal shown

step 5 step 6 step 8 disconnected state not purchased state
image image image image image

@MadhaviSeelam
Copy link

Not adding QA Pass - Win 64 label for Win 10 verification

@stephendonner
Copy link

Verification PASSED using

Brave | 1.61.62 Chromium: 119.0.6045.105 (Official Build) beta (64-bit)
-- | --
Revision | 435a38586472c662beec0fc75f622b7dfaa1e77d
OS | Windows 10 Version 22H2 (Build 19045.3636)

Steps:

  1. installed 1.61.62
  2. launched Brave
  3. purchased, configured, and connected to Brave VPN using account.bravesoftware.com
  4. confirmed VPN toolbar button shows green
  5. opened brave://skus-internals
  6. clicked Reset SKUs state button
  7. clicked OK

Confirmed VPN toolbar button shows grey, disconnected state

Confirmed when clicking on the VPN button, not-purchased state modal shown

Step 5 Step 6 Step 8 Disconnected state Not purchased state
image image image image image

@stephendonner
Copy link

stephendonner commented Nov 7, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.61.67 Chromium: 119.0.6045.105 (Official Build) beta (x86_64)
-- | --
Revision | 09cc687dc27ccd8acafeebf5af1dc620b4d9cb22
OS | macOS Version 14.2 (Build 23C5030f)

Steps:

  1. installed 1.61.67
  2. launched Brave
  3. purchased, configured, and connected to Brave VPN using account.bravesoftware.com
  4. confirmed VPN toolbar button shows green
  5. opened brave://skus-internals
  6. clicked Fetch SKUs state
  7. confirmed it populated with credentials
  8. clicked Reset SKUs state button
  9. clicked OK

Confirmed VPN toolbar button shows grey, disconnected state

Confirmed when clicking on the VPN button, not-purchased state modal shown

step 5 step 6 step 9 Disconnected state Not purchased state
Screenshot 2023-11-07 at 1 04 15 PM Screenshot 2023-11-07 at 1 06 10 PM Screenshot 2023-11-07 at 1 07 14 PM Screenshot 2023-11-07 at 1 10 14 PM Screenshot 2023-11-07 at 1 08 56 PM

@simonhong simonhong mentioned this issue Nov 10, 2023
Closed
@simonhong simonhong mentioned this issue Nov 22, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Nov 23, 2023 •
edited
Loading

Removing the QA-Pass labels as the above was uplifted from 1.61.x into 1.60.x so we'll need to re-check against the 1.60.x branch once we have RC's available with the above fix. Used the above verifications for uplift.

The above requires 1.60.123 or higher for 1.60.x verification 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 27, 2023 •
edited
Loading

Verified PASSED on

Brave | 1.60.124 Chromium: 119.0.6045.163 (Official Build) (64-bit)
-- | --
Revision | 803c85554783c998a840f4b211c94236409a9928
OS | Windows 10 Version 22H2 (Build 19045.3693)

Steps:

  1. installed 1.61.124
  2. launched Brave
  3. purchased, configured, and connected to Brave VPN using account.bravesoftware.com
  4. confirmed VPN toolbar button shows green
  5. opened brave://skus-internals
  6. clicked Fetch SKUs state
  7. confirmed it populated with credentials
  8. clicked Reset SKUs state button
  9. clicked OK

Confirmed VPN toolbar button shows grey, disconnected state

Confirmed when clicking on the VPN button, not-purchased state modal shown

step 5 step 6 step 9 Disconnected state Not purchased state
image image image image image

@LaurenWags
Copy link
Member

LaurenWags commented Nov 27, 2023 •
edited
Loading

Verified with

Brave | 1.60.124 Chromium: 119.0.6045.163 (Official Build) (x86_64)
-- | --
Revision | 803c85554783c998a840f4b211c94236409a9928
OS | macOS Version 13.6.1 (Build 22G313)

Reproduced the issue using 1.60.118 Chromium: 119.0.6045.163:

  1. installed 1.60.118
  2. launched Brave
  3. purchased, configured, and connected to Brave VPN using account.bravesoftware.com
  4. confirmed VPN toolbar button shows green
  5. opened brave://skus-internals
  6. clicked Fetch SKUs state
  7. confirmed it populated with credentials
  8. clicked Reset SKUs state button
  9. clicked OK
step 4 step 6 step 8 step 9
4 6 8 no disconnected state

After following above steps:

  • VPN toolbar button shows green, active/connected state
  • When clicking on the VPN button, active/connected state is shown (on the panel)
  • If you close/reopen the panel, you will see that the button shows green, active/connected state, but the panel shows "Not purchased" state
Example Example Example
no disconnected state panel shows connected' button is green and shows not purchased state

Verified issue is resolved with below STR:

  1. installed 1.60.x
  2. launched Brave
  3. purchased, configured, and connected to Brave VPN using account.bravesoftware.com
  4. confirmed VPN toolbar button shows green
  5. opened brave://skus-internals
  6. clicked Fetch SKUs state
  7. confirmed it populated with credentials
  8. clicked Reset SKUs state button
  9. clicked OK

Confirmed VPN toolbar button shows grey, disconnected state

Confirmed when clicking on the VPN button, not-purchased state modal shown (on the panel)

step 4 step 6 step 8 Disconnected state (button) Not purchased state (panel)
5 6 8 9 not purchased

@stephendonner
Copy link

stephendonner commented Nov 27, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.60.124 Chromium: 119.0.6045.163 (Official Build) (x86_64)
-- | --
Revision | 803c85554783c998a840f4b211c94236409a9928
OS | macOS Version 11.7.10 (Build 20G1427)

First, confirmed the issue using 1.60.118

example example example example
Screen Shot 2023-11-27 at 9 31 05 AM Screen Shot 2023-11-27 at 9 39 56 AM Screen Shot 2023-11-27 at 9 40 00 AM Screen Shot 2023-11-27 at 9 40 03 AM

Steps:

  1. installed 1.60.x
  2. launched Brave
  3. purchased, configured, and connected to Brave VPN using account.bravesoftware.com
  4. confirmed VPN toolbar button shows green
  5. opened brave://skus-internals
  6. clicked Fetch SKUs state
  7. confirmed it populated with credentials
  8. clicked Reset SKUs state button
  9. clicked OK

Confirmed VPN toolbar button shows grey, disconnected state

Confirmed when clicking on the VPN button, not-purchased state modal shown (on the panel)

step 4 step 6 step 8 Disconnected state (button) Not purchased state (panel)
Screen Shot 2023-11-27 at 9 11 05 AM Screen Shot 2023-11-27 at 9 14 33 AM Screen Shot 2023-11-27 at 9 14 41 AM Screen Shot 2023-11-27 at 9 14 48 AM Screen Shot 2023-11-27 at 9 15 18 AM

@LaurenWags LaurenWags mentioned this issue Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/vpn OS/Desktop OS/macOS OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.60.x - Release #5
Development

Successfully merging a pull request may close this issue.

Fixed vpn button still has connected state for not purchased user brave/brave-core
8 participants
@stephendonner @kjozwiak @rebron @simonhong @LaurenWags @GeetaSarvadnya @brave-builds @MadhaviSeelam