Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed vpn button still has connected state for not purchased user(uplift to 1.60.x) #21083

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Fixed vpn button still has connected state for not purchased user(uplift to 1.60.x) #21083

merged 2 commits into from
Nov 23, 2023

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Nov 22, 2023 •
edited by kjozwiak
Loading

Uplift of #20533
Uplift of #20386 (as #20533 depends on this)
Resolves brave/brave-browser#33023

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@simonhong
Merge pull request #20386 from brave/button-update
2b48c09 
Remove brave vpn toolbar button flashes when reconnecting multiple times
@simonhong
Merge pull request #20533 from brave/vpn_button_state_purchased_state
76e7953 
Fixed vpn button still has connected state for not purchased user
@simonhong simonhong self-assigned this Nov 22, 2023
@simonhong simonhong requested a review from a team as a code owner November 22, 2023 09:15
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Nov 22, 2023
@kjozwiak kjozwiak added this to the 1.60.x - Release #5 milestone Nov 23, 2023
kjozwiak
kjozwiak approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.60.x approved 👍 QA has verified the PR on BETA as per brave/brave-browser#33023 (comment), brave/brave-browser#33023 (comment) & brave/brave-browser#33023 (comment).

@kjozwiak kjozwiak merged commit 91128b5 into 1.60.x Nov 23, 2023
@kjozwiak kjozwiak deleted the uplift_20533 branch November 23, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@simonhong simonhong

Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.60.x - Release #5
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhong @kjozwiak