Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context indicator changes #34099

Closed
3 tasks
bbondy opened this issue Nov 3, 2023 · 5 comments · Fixed by brave/brave-core#20966
Closed
3 tasks

Context indicator changes #34099

bbondy opened this issue Nov 3, 2023 · 5 comments · Fixed by brave/brave-core#20966
Assignees
Labels
browser-ai feature/user-interface All UI related OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include

Comments

@bbondy
Copy link
Member

bbondy commented Nov 3, 2023

  • Change the connected to page UI to be less confusing. It will now be a toggle underneath and glued to the input box. Default to ON
  • If the user turns it off, remove the Summarize this page button
  • After context is included in a conversation the switch should disappear and it should go into the scrollable history instead.

image (55)
Screenshot 2023-11-15 at 12 52 25 PM

Screenshot 2023-11-15 at 12 53 16 PM
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 3, 2023
@bbondy bbondy added this to Browser AI Nov 3, 2023
@bbondy bbondy moved this to Important / Polish in Browser AI Nov 3, 2023
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include labels Nov 3, 2023
@aguscruiz
Copy link

Figma link for reference
https://www.figma.com/file/m0Gdbf0wtqyfEFGm32VLLc/Leo?type=design&node-id=345-16732&mode=design

@kjozwiak
Copy link
Member

kjozwiak commented Dec 9, 2023

The above requires 1.62.101 or higher for 1.62.x verification 👍

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 13, 2023
@stephendonner
Copy link

stephendonner commented Dec 13, 2023

Verification PASSED using

Brave | 1.62.105 Chromium: 120.0.6099.71 (Official Build) beta (64-bit)
-- | --
Revision | f72c783bcd52110d026061575b4bef28ccb547f7
OS | Windows 10 Version 22H2 (Build 19045.3803)

Use page content for response - Enabled

Steps:

  1. installed 1.62.105
  2. launched Brave
  3. loaded vice.com
  4. clicked on the Leo icon in the sidebar
  5. left default Use page context for response toggle On/Enabled
  6. clicked on Summarize this page
  7. waited for summary output
  8. clicked on Suggest questions...

Confirmed page-contextual output and the Use page context for response toggle is now hidden

example example example example example
image image image image image

Use page content for response - Disabled

Steps:

  1. installed 1.62.105
  2. launched Brave
  3. loaded vice.com
  4. clicked on the Leo icon in the sidebar
  5. toggled Use page context for response to Off/Disabled
  6. entered Summarize this page and clicked Send message to Leo
  7. waited for summary output

Confirmed the summary output was NOT contextual to anything on vice.com

example example example example example
image image image image image

@stephendonner stephendonner added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 13, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 22, 2023

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.62.121

  • Verified the description from the issue Context indicator changes #34099 (comment)
  • Confirmed that Use page context for response toggle present underneath and glued to the input box.
  • Confirmed that Use page context for response toggle is ON by default
  • Confirmed that Use page context for response toggle disappers when user selects Summerize this page button
Example Example Example Example
Screenshot_20231227_150121 Screenshot_20231227_150135 Screenshot_20231227_150139 Screenshot_20231227_150153
  • Confirmed that, if user turn off the the Use page context for response button then Summarize this page and Sugges questions buttons are disappeared
Example Example
Screenshot_20231227_150102 Screenshot_20231227_150109

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 22, 2023
@GeetaSarvadnya GeetaSarvadnya added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 27, 2023
@kjozwiak
Copy link
Member

Removing the above from #35625 as Leo is targeting 1.63.x for Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-ai feature/user-interface All UI related OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants