AIChat: new welcome opt-in ux and contextual toggle #20966

nullhook · 2023-11-13T17:41:16Z

Resolves brave/brave-browser#34099
Resolves brave/brave-browser#33942

This PR introduces a new welcome guide for users who haven't agreed to the policy terms. Once the user has viewed and accepted the policy, the welcome guide will no longer be displayed.

Additionally, adds a toggle near the input area for users to control if the page contents should be attached to the conversation or not.

the toggle is only visible and controllable before the conversation starts
once you've start the chat you'll be locked in with what you've selected
the site title indicator has moved in the chat history itself

Submitter Checklist:

I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally:
- npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
- npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

brave-builds · 2023-11-13T18:45:38Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-11-14T16:21:30Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-11-14T16:21:35Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-11-16T00:31:48Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-11-17T04:27:39Z

A Storybook has been deployed to preview UI for the latest push

petemill

This has an issue with the new welcome UX: If I uncheck the new toggle on the Welcome screen, the "Summarize" button doesn't disappear. If I click that then I get a state which seems to say it's about the page but it's missing the title (and it isn't about the page):

In fact this is a problem submitting any input in the Welcome UX, not just the "Summarize" built-in entry suggestion.

brave-builds · 2023-11-20T14:12:48Z

A Storybook has been deployed to preview UI for the latest push

nullhook · 2023-11-20T16:27:28Z

thanks for spotting. you should be able to see the correct behavior now.

brave-builds · 2023-11-20T16:51:57Z

A Storybook has been deployed to preview UI for the latest push

components/ai_chat/core/browser/conversation_driver.cc

petemill · 2023-11-21T01:50:24Z

components/ai_chat/resources/page/components/page_context_toggle/index.tsx

+    getPageHandlerInstance().pageHandler.setShouldSendPageContents(
+      e.detail.checked
+    )


This is more of a nit, but one thing concerns me here - we only show this Toggle when the associated page has SiteInfo. When we call setShouldSendPageContents, which this toggle is calling directly itself, we're clearing the page content and technically SiteInfo should indicate there's no page present, which would hide this very toggle as soon as it's diabled. I think that potential bug is avoided because we only re-fetch SiteInfo in f/e initialiseForTargetTab. It seems an easy future regression when that state gets updated whenever page association / site info changes.

brave-builds · 2023-11-21T16:52:11Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-11-21T19:58:14Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-11-21T19:58:23Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-11-21T21:42:06Z

A Storybook has been deployed to preview UI for the latest push

petemill · 2023-11-28T08:37:17Z

This now has commits from the new welcome opt-in PR #20750, so I suppose that means it's blocked on that now?

brave-builds · 2023-11-28T16:39:49Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-11-30T07:32:20Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-11-30T20:08:07Z

A Storybook has been deployed to preview UI for the latest push

github-actions · 2023-12-01T07:28:38Z

[puLL-Merge] - brave/brave-core@20966

The patch introduces changes to an AI chat feature, which includes updates to user experience (UX) elements and logic.

Key changes included in the patch:

Introduction of a new opt-in UX for the AI chat feature.
Property changes and logic enhancements for site information handling.
Renaming and refactoring of code for clarity.
Addition of new SVG (Scalable Vector Graphics) components and a welcome guide component with related styling.
Logic for toggling whether page context should be included in the conversation or not.
Adjustments to how suggested questions are displayed and when the summarize page button is shown.
Assorted bug fixes and code improvements.

Files affected by the patch are predominantly Typescript (.tsx) components, C++ (.cc and .h) files, and resource definitions (.grdp) that manage strings for localization.

Specific updates mentioned in the patch commits include:

Changing the handling of a boolean value indicating whether to send page content as part of a conversation.
Improvements to how site information and content association status are managed.
Allowing a 'special summarization request' to be made.
Introducing a toggle for users to decide if they want to include page context in AI chat responses.
Ensuring UI elements are accessible and properly positioned.

The patch seems to be part of a series, as indicated by the "[PATCH 01/13]" in the description, which implies there are other related patches in the sequence. Each affected file is listed along with the details of insertions (+), modifications ( ), and deletions (-) provided in a summary at the top of the patch. The patch applies these changes to the codebase, likely contributing to the development of the AI chat feature.

brave-builds · 2023-12-01T08:00:19Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-12-01T08:00:34Z

A Storybook has been deployed to preview UI for the latest push

- dont send opt-in bool - siteinfo has a new prop - rename pending conversation entries - uses nala dialog - nala dialog width should work - flush welcome guide to bottom - introducing should_show_questions prop - added pending_message_needs_page_content_ - siteInfo is non-optional - added logic to show_suggestion bool - special summarization request

- remove prop in siteInfo - DCHECK to avoid setter should_send_page_contents_ being set multiple times - DCHECK for special summarization request

…iated with content

…eady yet

brave-builds · 2023-12-01T18:44:35Z

A Storybook has been deployed to preview UI for the latest push

stephendonner · 2023-12-05T22:20:13Z

Verification `PASSED` using

Brave | 1.63.12 Chromium: 120.0.6099.56 (Official Build) nightly (64-bit)
-- | --
Revision | 7517dcc0934f42a59a43477bca4ebefc18d7e14f
OS | Windows 10 Version 22H2 (Build 19045.3693)

Context-indicator changes - brave/brave-browser#34099 - `PASSED`

Steps:

installed 1.63.12
launched Brave
loaded https://plus.nasa.gov/scheduled-video/iss-expedition-70-in-flight-event-to-mark-the-25th-anniversary-of-the-mating-of-the-zarya-and-unity-modules/
clicked on Leo in the sidebar
toggled Use page context for response to Off
clicked on Summarize this page
clicked on Accept and begin
waited for the response output

Confirmed `Summarize this page` button and the `Use page context for response` toggle are now hidden, with `Suggest questions...` still there

`step 4`	`step 5`	`step 6`	`step 7`

New AI Chat opt-in experience - brave/brave-browser#33942 - `PASSED`

Steps:

installed 1.63.12
launched Brave
loaded vox.com
clicked on Leo in the sidebar
clicked on Summarize this page
clicked on Accept and begin
waited
scrolled to the bottom of the answer text
confirmed answer was well-formed and complete
loaded vox.com again

Confirmed opt-in prompt disappears after the 1st summary or question answered

Also repeated the above, but using a manually-entered question to trigger it, instead

example	example	example	example	example

* aichat: new opt-in ux * simplify siteInfo * aichat: toggle page context responses from LLM * moved build site info to conversation driver * special summarize button visibility depends on toggle * MakeAPIRequestWithConversationHistoryUpdate accepts a flag * show model intro on all pages * AI Chat: Don't show suggested questions when conversation isn't associated with content * AI Chat: conversation entry should also be pending if content isn't ready yet --------- Co-authored-by: Pete Miller <miller.pete@gmail.com>

…1314) * Merge pull request #21063 from brave/ai-chat-summary-prompt-force-english ai chat: fix summary prompt for pages is being translated * AIChat: new welcome opt-in ux and contextual toggle (#20966) * aichat: new opt-in ux * simplify siteInfo * aichat: toggle page context responses from LLM * moved build site info to conversation driver * special summarize button visibility depends on toggle * MakeAPIRequestWithConversationHistoryUpdate accepts a flag * show model intro on all pages * AI Chat: Don't show suggested questions when conversation isn't associated with content * AI Chat: conversation entry should also be pending if content isn't ready yet --------- Co-authored-by: Pete Miller <miller.pete@gmail.com> --------- Co-authored-by: Pete Miller <miller.pete@gmail.com>

github-actions bot assigned nullhook Nov 13, 2023

github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 13, 2023

nullhook force-pushed the ai-chat-contextual-toggle branch 4 times, most recently from 644c5db to 293184a Compare November 15, 2023 23:33

nullhook marked this pull request as ready for review November 17, 2023 03:56

nullhook requested a review from a team as a code owner November 17, 2023 03:56

nullhook requested a review from petemill November 17, 2023 03:56

petemill requested changes Nov 19, 2023

View reviewed changes

nullhook force-pushed the ai-chat-contextual-toggle branch from e3fc70e to 1536f31 Compare November 20, 2023 13:16

nullhook force-pushed the ai-chat-contextual-toggle branch from 1536f31 to 7b5ae3e Compare November 20, 2023 16:26

petemill requested changes Nov 21, 2023

View reviewed changes

nullhook force-pushed the ai-chat-contextual-toggle branch from 7b5ae3e to 2e030e6 Compare November 21, 2023 16:16

nullhook requested a review from petemill November 21, 2023 21:09

nullhook force-pushed the ai-chat-contextual-toggle branch from 39b325d to 07d8d58 Compare November 28, 2023 15:40

nullhook requested a review from petemill November 30, 2023 17:10

petemill approved these changes Dec 1, 2023

View reviewed changes

nullhook and others added 13 commits December 1, 2023 09:32

simplify siteInfo

1332c65

aichat: toggle page context responses from LLM

2dfaeaa

- remove prop in siteInfo - DCHECK to avoid setter should_send_page_contents_ being set multiple times - DCHECK for special summarization request

moved build site info to conversation driver

8011320

special summarize button visibility depends on toggle

9ee82be

remove an observer call

c7a0c4b

resolved feedback

a9abad7

MakeAPIRequestWithConversationHistoryUpdate accepts a flag

8a72478

show model intro on all pages

556e02c

shouldSendPageContent is aliased on the frontend

3116dcd

toggle is accessible now

789f7b0

AI Chat: Don't show suggested questions when conversation isn't assoc…

d8772bd

…iated with content

AI Chat: conversation entry should also be pending if content isn't r…

48d4bd5

…eady yet

petemill force-pushed the ai-chat-contextual-toggle branch from f51d025 to 48d4bd5 Compare December 1, 2023 17:32

petemill merged commit 058825f into master Dec 1, 2023
18 checks passed

petemill deleted the ai-chat-contextual-toggle branch December 1, 2023 20:01

github-actions bot added this to the 1.63.x - Nightly milestone Dec 1, 2023

nullhook mentioned this pull request Dec 8, 2023

aichat: new-opt-in, toggle and prompt changes uplifting to 1.62.x #21314

Merged

petemill mentioned this pull request Feb 16, 2024

AI Chat fix premium upsell not showing #22131

Open

24 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AIChat: new welcome opt-in ux and contextual toggle #20966

AIChat: new welcome opt-in ux and contextual toggle #20966

nullhook commented Nov 13, 2023 •

edited

Loading

brave-builds commented Nov 13, 2023

brave-builds commented Nov 14, 2023

brave-builds commented Nov 14, 2023

brave-builds commented Nov 16, 2023

brave-builds commented Nov 17, 2023

petemill left a comment

brave-builds commented Nov 20, 2023

nullhook commented Nov 20, 2023

brave-builds commented Nov 20, 2023

petemill Nov 21, 2023

brave-builds commented Nov 21, 2023

brave-builds commented Nov 21, 2023

brave-builds commented Nov 21, 2023

brave-builds commented Nov 21, 2023

petemill commented Nov 28, 2023

brave-builds commented Nov 28, 2023

brave-builds commented Nov 30, 2023

brave-builds commented Nov 30, 2023

github-actions bot commented Dec 1, 2023

brave-builds commented Dec 1, 2023

brave-builds commented Dec 1, 2023

brave-builds commented Dec 1, 2023

stephendonner commented Dec 5, 2023 •

edited

Loading

Steps:

Confirmed `Summarize this page` button and the `Use page context for response` toggle are now hidden, with `Suggest questions...` still there

Steps:

Steps:

Confirmed opt-in prompt disappears after the 1st summary or question answered

Also repeated the above, but using a manually-entered question to trigger it, instead

AIChat: new welcome opt-in ux and contextual toggle #20966

AIChat: new welcome opt-in ux and contextual toggle #20966

Conversation

nullhook commented Nov 13, 2023 • edited Loading

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

brave-builds commented Nov 13, 2023

brave-builds commented Nov 14, 2023

brave-builds commented Nov 14, 2023

brave-builds commented Nov 16, 2023

brave-builds commented Nov 17, 2023

petemill left a comment

Choose a reason for hiding this comment

brave-builds commented Nov 20, 2023

nullhook commented Nov 20, 2023

brave-builds commented Nov 20, 2023

petemill Nov 21, 2023

Choose a reason for hiding this comment

brave-builds commented Nov 21, 2023

brave-builds commented Nov 21, 2023

brave-builds commented Nov 21, 2023

brave-builds commented Nov 21, 2023

petemill commented Nov 28, 2023

brave-builds commented Nov 28, 2023

brave-builds commented Nov 30, 2023

brave-builds commented Nov 30, 2023

github-actions bot commented Dec 1, 2023

brave-builds commented Dec 1, 2023

brave-builds commented Dec 1, 2023

brave-builds commented Dec 1, 2023

stephendonner commented Dec 5, 2023 • edited Loading

Verification PASSED using

Context-indicator changes - brave/brave-browser#34099 - PASSED

Steps:

Confirmed Summarize this page button and the Use page context for response toggle are now hidden, with Suggest questions... still there

Suggested questions and context-indicator changes - brave/brave-browser#33575 - PASSED

Steps:

New AI Chat opt-in experience - brave/brave-browser#33942 - PASSED

Steps:

Confirmed opt-in prompt disappears after the 1st summary or question answered

Also repeated the above, but using a manually-entered question to trigger it, instead

nullhook commented Nov 13, 2023 •

edited

Loading

stephendonner commented Dec 5, 2023 •

edited

Loading

Verification `PASSED` using

Context-indicator changes - brave/brave-browser#34099 - `PASSED`

Confirmed `Summarize this page` button and the `Use page context for response` toggle are now hidden, with `Suggest questions...` still there

Suggested questions and context-indicator changes - brave/brave-browser#33575 - `PASSED`

New AI Chat opt-in experience - brave/brave-browser#33942 - `PASSED`